Re: [PATCH] ARM: KVM: don't let set_hdcr corrupt the result of set_hcptr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 22, 2012 at 7:04 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
> set_hcptr reports the previous HCPTR value in r2. We use that
> value to work out if we need to restore the host VFP context.
>
> Unfortunately, inserting set_hdcr in between leads to interesting
> effects.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> ---
>  arch/arm/kvm/interrupts.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S
> index a03de6e..2665925 100644
> --- a/arch/arm/kvm/interrupts.S
> +++ b/arch/arm/kvm/interrupts.S
> @@ -606,8 +606,8 @@ __kvm_vcpu_return:
>
>         @ Don't trap coprocessor accesses for host kernel
>         set_hstr 0
> -       set_hcptr 0, (HCPTR_TTA | HCPTR_TCP(10) | HCPTR_TCP(11))
>         set_hdcr 0
> +       set_hcptr 0, (HCPTR_TTA | HCPTR_TCP(10) | HCPTR_TCP(11))
>
>  #ifdef CONFIG_VFPv3
>         @ Save floating point registers we if let guest use them.
> --
> 1.7.11.4
>

nice catch, thanks!
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux