Re: [PATCH] ARM: KVM: vfp: move VFP structs towards the top of kvm_vcpu struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 7, 2012 at 2:44 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
> Move fields accessed by assembly code to the beginning of
> the kvm_vcpu struct (well, closer anyway).
>
> Cc: Antonios Motakis <a.motakis@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> ---
>  arch/arm/include/asm/kvm_host.h |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
> index 055ca79..1e4366e 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -114,6 +114,14 @@ struct kvm_vcpu_arch {
>         u64 pc_ipa2;            /* same as above, but for non-aligned wide thumb
>                                    instructions */
>
> +       /* Floating point registers (VFP and Advanced SIMD/NEON) */
> +       struct vfp_hard_struct vfp_guest;
> +       struct vfp_hard_struct vfp_host;
> +
> +       /*
> +        * Anything that is not used directly from assembly code goes
> +        * here.
> +        */
>         /* dcache set/way operation pending */
>         int last_pcpu;
>         cpumask_t require_dcache_flush;
> @@ -127,10 +135,6 @@ struct kvm_vcpu_arch {
>
>         /* Hyp exception information */
>         u32 hyp_pc;             /* PC when exception was taken from Hyp mode */
> -
> -       /* Floating point registers (VFP and Advanced SIMD/NEON) */
> -       struct vfp_hard_struct vfp_guest;
> -       struct vfp_hard_struct vfp_host;
>  };
>
>  struct kvm_vm_stat {
> --
> 1.7.10.3
>

why this patch?

it breaks compilation with enough debugging options turned on (all
that lock debugging stuff...)

-Christoffer
_______________________________________________
kvmarm mailing list
kvmarm@xxxxxxxxxxxxxxxxxxxxx
https://lists.cs.columbia.edu/cucslists/listinfo/kvmarm


[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux