On Wed, May 23, 2012 at 10:39 AM, Marc Zyngier <marc.zyngier at arm.com> wrote: > HCR_GUEST_MASK looks like a random bag of hard to read acronyms. > Add a tiny bit of comment so people get a chance of understanding > what we're doing without having to dive into the ARM ARM. > > Signed-off-by: Marc Zyngier <marc.zyngier at arm.com> > --- > ?arch/arm/include/asm/kvm_arm.h | ? 13 +++++++++++++ > ?1 file changed, 13 insertions(+) > > diff --git a/arch/arm/include/asm/kvm_arm.h b/arch/arm/include/asm/kvm_arm.h > index b9e4197..d76e8eb37 100644 > --- a/arch/arm/include/asm/kvm_arm.h > +++ b/arch/arm/include/asm/kvm_arm.h > @@ -48,6 +48,19 @@ > ?#define HCR_PTW ? ? ? ? ? ? ? ?(1 << 2) > ?#define HCR_SWIO ? ? ? (1 << 1) > ?#define HCR_VM ? ? ? ? 1 > + > +/* > + * The bits we set in HCR: > + * TAC: ? ? ? ? ? ? ? ?Trap ACTLR > + * TSC: ? ? ? ? ? ? ? ?Trap SMC > + * TWI: ? ? ? ? ? ? ? ?Trap WFI > + * BSU_IS: ? ? Upgrade barriers to the inner shareable domain > + * FB: ? ? ? ? Force broadcast of all maintainance operations > + * AMO: ? ? ? ? ? ? ? ?Override CPSR.A and enable signaling with VA > + * IMO: ? ? ? ? ? ? ? ?Override CPSR.I and enable signaling with VI > + * FMO: ? ? ? ? ? ? ? ?Override CPSR.F and enable signaling with VF > + * SWIO: ? ? ? Turn set/way invalidates into set/way clean+invalidate > + */ > ?#define HCR_GUEST_MASK (HCR_TSC | HCR_TWI | HCR_VM | HCR_BSU_IS | HCR_FB | \ > ? ? ? ? ? ? ? ? ? ? ? ?HCR_TAC | HCR_AMO | HCR_IMO | HCR_FMO | HCR_SWIO) > ?#define HCR_VIRT_EXCP_MASK (HCR_VA | HCR_VI | HCR_VF) > -- > 1.7.10.1 ack thanks, Christoffer
