On Thu, Mar 29, 2012 at 6:49 AM, Avi Kivity <avi at redhat.com> wrote: > On 03/28/2012 11:57 PM, Rusty Russell wrote: >> > > >> > > Should this code be dropped altogether? ?Peter points out that once we >> > > add new regs, they *must* be initialized to correct reset values in case >> > > older QEMU knows nothing about them, but for the rest it just seems >> > > confusing... >> > > >> > >> > It's best to initialize everything. ?As far as this code is concerned >> > qemu is just another user and we shouldn't rely on its implementation. >> >> In which case, qemu should not initialize anything, but read the >> registers from the kernel to start with. > > qemu has its own set of considerations. ?For example, it needs to > initialize registers in tcg mode. ?But that's another discussion. > sorry about the late response on this one. This code should be changed to initialize to reset values for all the registers. Thanks.
