On Tue, Mar 13, 2012 at 8:58 PM, Rusty Russell <rusty at rustcorp.com.au> wrote: > On Tue, 13 Mar 2012 16:49:19 +0000, Peter Maydell <peter.maydell at linaro.org> wrote: >> On 13 March 2012 16:32, Peter Maydell <peter.maydell at linaro.org> wrote: >> > http://lxr.linux.no/#linux+v3.2.9/arch/arm/nwfpe/fpopcode.c#L64 >> > >> > I think I prefer the pure-C implementation myself. >> >> ...now available in a more sensible location in recent kernels: >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=arch/arm/kernel/opcodes.c;h=f8179c6a817f08663e3f72576c9cdce37e74122a;hb=HEAD >> >> -- so we should definitely just be calling arm_check_condition(). > > For sure, I didn't realize it existed already. ?I didn't want to risk > getting it wrong, hence my naive approach. > > All that asm, going to waste! :) > hey, you're now on top of reading the PC in ARM asm... ;)
