>>> >>> - ? ? ? ret = create_hyp_io_mappings(kvm_hyp_pgd, >>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?vgic_vctrl_base, >>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?vgic_vctrl_base + VGIC_VCTRL_SIZE, >>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?VGIC_VCTRL_BASE); >>> + ? ? ? ret = create_hyp_io_mappings(vgic_vctrl_base, >>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?vgic_vctrl_base + resource_size(&vctrl_res), >>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?vctrl_res.start); >> >> I guess this change should have been applied further down the patch >> series, but no problem, the VGIC support is going to be flattened >> anyhow. > > This patch is intended to be merged with the previous ones. But I'd like > to keep the VGIC series mostly as it is (unflattened). Nobody wants to > review a single 2000+ line patch. > absolutely, but the previous version of this patch would break bisectability given the current base. -Christoffer