On 25/06/12 22:16, Christoffer Dall wrote: > On Mon, May 14, 2012 at 9:07 AM, Marc Zyngier <marc.zyngier at arm.com> wrote: >> It is now possible to select CONFIG_KVM_ARM_TIMER to enable the >> KVM architected timer support. >> >> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com> >> --- >> arch/arm/kvm/Kconfig | 7 +++++++ >> arch/arm/kvm/Makefile | 1 + >> arch/arm/kvm/arm.c | 11 +++++++++++ >> arch/arm/kvm/vgic.c | 4 ++++ >> 4 files changed, 23 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig >> index b2860fc..b0eb7a3 100644 >> --- a/arch/arm/kvm/Kconfig >> +++ b/arch/arm/kvm/Kconfig >> @@ -47,6 +47,13 @@ config KVM_ARM_VGIC >> ---help--- >> Adds support for a hardware assisted, in-kernel GIC emulation. >> >> +config KVM_ARM_TIMER >> + bool "KVM support for Architected Timers" >> + depends on KVM_ARM_VGIC && ARM_ARCH_TIMER >> + select HAVE_KVM_IRQCHIP >> + ---help--- >> + Adds support for the Architected Timed in virtual machines >> + > > What happens if you run a guest without architected timers support and > the support on the KVM host side is enabled? Nothing. > If nothing, then why do we have a separate config option for this and > not just selecting it as part of KVM_ARM_VGIC? Because I'm paranoid and like to be able to disable things and check that we don't introduce regressions. Same on the host side, actually. You can enable ARM_ARCH_TIMERS, or not. M. -- Jazz is not dead. It just smells funny...
