On Mon, May 14, 2012 at 12:26 PM, Marc Zyngier <marc.zyngier at arm.com> wrote: > On 14/05/12 16:48, Peter Maydell wrote: >> On 14 May 2012 14:06, Marc Zyngier <marc.zyngier at arm.com> wrote: >>> This patch series adds support for the architected timer for the >>> guest. It relies on the VGIC code to inject timer interrupts. >> >> This seems like a good point to raise the suggestion that >> using the in-kernel support for the architected timer and >> VGIC should be mandatory. > > Indeed, thanks for pointing this out. This is why CONFIG_KVM_ARM_TIMER > depends on KVM_ARM_VGIC && ARM_ARCH_TIMER. > is it really that clear that we should just mandate this? If we are really sure that there will not be devices with virtualization extensions without GIC virtualization extensions support then fine (???). Otherwise, I think we definitely want to support such configurations. Regarding running a guest A9 type thing, I think there are many places where we can severely simplify by assuming that we emulate what we are running on. As Marc also pointed out how will that otherwise work with erratas etc., so my only concern is the above. (Sorry for the huge delay in responding to this). -Christoffer
