[Android-virt] [PATCH v3 1/2] Makefile: Introduced super-simple config file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 5, 2012 at 7:24 PM, Peter Maydell <peter.maydell at linaro.org> wrote:
> On 9 December 2011 20:24, Christoffer Dall
> <c.dall at virtualopensystems.com> wrote:
>> Config files are named config.mk. This file is added to .gitignore,
>> but a default config file is supplied in config-default.mk.
>>
>> The default config file creates kernel command boot lines for NFS boots
>> based on a script obtaining the host IP addres. Naturally users can
>> change this to a static IP or another script if they wish.
>
> So I think it would be nice to automatically rebuild if the IP address
> changes (or if the kernel command line changes for some other reason).
> There are a couple of options here. We could be clever:
>
> boot.o: $(BOOTLOADER) kcmd-value
> ? ? ? ?[same rule as we have now to build boot.o]
>
> kcmd-value: force
> ? ? ? ?echo $(FOO) >kcmd-value.new
> ? ? ? ?cmp kcmd-value kcmd-value.new || mv -f kcmd-value.new kcmd-value
>
> but since in fact rebuilding boot.o takes almost no time and we already
> spend plenty of time in the kernel's makefile if you do a "make" and there's
> nothing to do, perhaps it would be simpler just to mark boot.o as "force"
> so we always rebuild boot.o regardless ?
>

I definitely think so. It really takes _no_ time compared to the rest.
The only downside would be the illusion of something having changed,
even though nothing has, which may be confusing. For me personally it
would not, but I don't pretend to know the work flow of all other
developers using this.



[Index of Archives]     [Linux KVM]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux