On Sun, Jun 5, 2011 at 2:41 PM, Avi Kivity <avi at redhat.com> wrote: > On 06/03/2011 06:03 PM, Christoffer Dall wrote: >> >> Initializes a blank level-1 translation table for the second stage >> translation and handles freeing it as well. >> >> + ? ? ? start = (unsigned long)kvm, >> + ? ? ? end = start + sizeof(struct kvm); >> + ? ? ? ret = create_hyp_mappings(kvm_hyp_pgd, start, end); > > Why not map all GFP_KERNEL memory? > I wanted to only map things I was sure would be there and stay there so no assumptions were made about existing pages which could have been removed, since I don't handle aborts taken in the hypervisor itself. But, if it would be as safe to map all GFP_KERNEL memory and that also maps the necessary code segments, then we could do that. Do you feel it would me simpler/faster/easier? > -- > error compiling committee.c: too many arguments to function > >
