On 12/12/2011 09:21 PM, Christoffer Dall wrote: > >> > >> well, if we block, but receive a signal that we want to go back into > >> userspace for, and then come back but the guest should still be > >> waiting, then I want that flag set, and I think it's the most logical > >> control flow. Am I missing something completely? > > > > That's just not the flow that the other archs use, I don't think that it > > really matters. kvm_vcpu_block() checks for and wakes up on signals, so > > it's okay to call it from here directly. > > > yes, but I still have to perform the check again in the main run > function if it woke up for anything else than a guest interrupt, so > why call it twice... You're right and in fact that's how x86 works too. I misremembered. -- error compiling committee.c: too many arguments to function
