On Wed, Mar 12, 2025 at 02:34:20PM +0000, David Woodhouse wrote: > From: David Woodhouse <dwmw@xxxxxxxxxxxx> > > A previous commit added __nocfi to machine_kexec() because it makes an > indirect call to relocate_kernel() which lacked CFI type information, > and caused the system to crash. > > Use SYM_TYPED_FUNC_START() to ensure that the type information is > present, and remove the __nocfi tag. > > I still can't make objtool happy with this in both GCC and Clang builds > at the same time, so not yet for merging; only included in this series > to nerd-snipe the objtool maintainers. Again, I'd recommend just compiling the code in .data..relocate_kernel. Then objtool doesn't need to care. Otherwise it would help to know what warnings you're getting with this patch, and the corresponding .config. -- Josh
