On 17 December 2024 10:54:19 CET, Ard Biesheuvel <ardb@xxxxxxxxxx> wrote: >On Tue, 17 Dec 2024 at 10:42, David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote: >> Hm, I am perfectly happy to believe that my memory is failing me, especially when it comes to specifics of i386 assembler code. But are you also telling me that >> <https://kernelnewbies.org/FAQ/asmlinkage> is a lie? >> > >It seems wildly out of date, at least. > >Commit 96a388de5dc53a8b2 from 2007 removed the asmlinkage definition >containing regparm(0) from include/asm-i386/linkage.h, No, it's still there in arch/x86/include/asm/linkage.h: <https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/include/asm/linkage.h#n20> And maybe you're right that it's a poorly named macro and we shouldn't conflate calling convention with linkage. But I think it *should* be part of the typedef.
