Re: [PATCH v2] Document/kexec: Generalize crash hotplug description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Boaquan,

On 13/08/24 14:47, Baoquan He wrote:
On 08/13/24 at 10:58am, Sourabh Jain wrote:
Hello Baoquan,

On 13/08/24 10:34, Baoquan He wrote:
On 08/12/24 at 09:46am, Sourabh Jain wrote:
......
---

Changelog:

Since v1: https://lore.kernel.org/all/20240805050829.297171-1-sourabhjain@xxxxxxxxxxxxx/
    - Update crash_hotplug sysfs document as suggested by Petr T
    - Update an error message in crash_handle_hotplug_event and
      crash_check_hotplug_support function.

---
......
diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 63cf89393c6e..c1048893f4b6 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -505,7 +505,7 @@ int crash_check_hotplug_support(void)
   	crash_hotplug_lock();
   	/* Obtain lock while reading crash information */
   	if (!kexec_trylock()) {
-		pr_info("kexec_trylock() failed, elfcorehdr may be inaccurate\n");
+		pr_info("kexec_trylock() failed, kdump image may be inaccurate\n");
Wondering why this need be updated.
In some architectures, additional kexec segments become obsolete during a
hotplug event,
so simply calling out the `elfcorehdr may be inaccurate` may not be
sufficient.
Therefore, it has been generalized with the kdump image.
OK, I forgot the case in ppc, makes sense to me, thx.

Acked-by: Baoquan He <bhe@xxxxxxxxxx>

Thanks for the Ack!

- Sourabh Jain

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux