On 07/02/24 at 10:00am, Sourabh Jain wrote: > Update the man page and --help option to make the description of the > --hotplug option easier to understand. > > Cc: Aditya Gupta <adityag@xxxxxxxxxxxxx> > Cc: Baoquan He <bhe@xxxxxxxxxx> > Cc: Coiby Xu <coxu@xxxxxxxxxx> > Cc: Mahesh Salgaonkar <mahesh@xxxxxxxxxxxxx> > Cc: Simon Horman <horms@xxxxxxxxxx> > Acked-by: Hari Bathini <hbathini@xxxxxxxxxxxxx> > Signed-off-by: Sourabh Jain <sourabhjain@xxxxxxxxxxxxx> > --- > Changelog: > > From v2 -> v3 > - Updated --hotplug option description > > --- > kexec/kexec.8 | 8 ++++---- > kexec/kexec.c | 4 +++- > 2 files changed, 7 insertions(+), 5 deletions(-) Acked-by: Baoquan He <bhe@xxxxxxxxxx> > > diff --git a/kexec/kexec.8 b/kexec/kexec.8 > index 9e995fe..793e876 100644 > --- a/kexec/kexec.8 > +++ b/kexec/kexec.8 > @@ -140,10 +140,10 @@ Open a help file for > .BR kexec . > .TP > .B \-\-hotplug > -Setup for kernel modification of the elfcorehdr. This option performs > -the steps needed to support kernel updates to the elfcorehdr in the > -presence of hot un/plug and/or on/offline events. This option only > -useful for KEXEC_LOAD syscall. > +Setup kexec segments such that kernel can safely update them on CPU/Memory > +hot add/remove events. If this option is enabled, kernel does in-kernel > +update of kexec segments on CPU/Memory hot add/remove events, thus avoiding > +the need to reload kdump kernel. > .TP > .B \-i\ (\-\-no-checks) > Fast reboot, no memory integrity checks. > diff --git a/kexec/kexec.c b/kexec/kexec.c > index 034cea6..9b7c34c 100644 > --- a/kexec/kexec.c > +++ b/kexec/kexec.c > @@ -1093,7 +1093,9 @@ void usage(void) > " back to the compatibility syscall when file based\n" > " syscall is not supported or the kernel did not\n" > " understand the image (default)\n" > - " --hotplug Setup for kernel modification of elfcorehdr.\n" > + " --hotplug Do in-kernel update of kexec segments on CPU/Memory\n" > + " hot add/remove events, avoiding the need to reload\n" > + " kdump kernel on online/offline events.\n" > " -d, --debug Enable debugging to help spot a failure.\n" > " -S, --status Return 1 if the type (by default crash) is loaded,\n" > " 0 if not.\n" > -- > 2.45.1 > _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
