Hi Coiby, On 05/23/24 at 01:04pm, Coiby Xu wrote: > LUKS is the standard for Linux disk encryption. Many users choose LUKS > and in some use cases like Confidential VM it's mandated. With kdump > enabled, when the 1st kernel crashes, the system could boot into the > kdump/crash kernel and dump the memory image i.e. /proc/vmcore to a > specified target. Currently, when dumping vmcore to a LUKS > encrypted device, there are two problems, I am done with this round of reviewing. The overall approach looks good to me, while there are places to improve or fix. I have added comment on all things I am concerned about, please check. Thanks for the effort. By the way, do you get confirmation on the solution from encryption/keys developer of redhat internally or upstream? With my understanding, it looks good. It may need their confirmation or approval in some ways. Thanks Baoquan _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
