On Wed, 11 Oct 2023 at 13:24, Song Shuai <songshuaishuai@xxxxxxxxxxx> wrote: > > > > 在 2023/9/20 19:56, Simon Horman 写道: > > On Fri, Sep 15, 2023 at 11:50:06AM +0800, Song Shuai wrote: > >> Hi, > >> > >> This series is created to improve RISC-V port of kexec-tools, > >> and is based on the horms/kexec-tools:build-test-riscv-v2 branch. > > > > In my mind the big question is how to move RISC-V support > > from that branch, to being merged into main. > > > > IIRC there were some issues that needed to be addressed. > > Perhaps they are all addressed by this series, and with > > some appropriate squashing we can move forwards with a series > > based on main? > > Hi, Simon and Nick: > > I squashed the first four patches as a "RISC-V: Some fixes for riscv > port" patch and then took the horms/main as the base to collect the 2 > patches from horms/build-test-riscv-v2 branch and this series togother. > These are the Github link and all commits for RISC-V. > > https://github.com/sugarfillet/kexec-tools/commits/main_rv > > 5dc133e RISC-V: Support loading Image binary file > b042f6d RISC-V: Separate elf_riscv_find_pbase out > 8f344c7 RISC-V: Enable kexec_file_load syscall > 7d4b982 RISC-V: Some fixes for riscv port > 3205c1c local: RISC-V: distribute purgatory/riscv/Makefile > 54f9daf RISC-V: Add support for riscv kexec/kdump on kexec-tools > > Since I didn't found the issues/fixes as Nick mentioned with these > commits, I prefer to merge them into horms/main and let more kexec/kdump > users to help improve/fixup RISC-V port. Hi, I noticed another pr for Fedora kexec-tools: https://src.fedoraproject.org/rpms/kexec-tools/pull-request/24 It is bad to take it as Fedora only, I would suggest posting all the refreshed patches together here again for review. If no enough reviewers can review them my another suggestion is to drop the kexec_load support code for the time being, and only enable the kexec_file_load support code in kexec-tools, and I assume below kernel commit make the kexec_file_load kernel piece of work done. Then it will be easier to review and make something working at least. commit 6261586e0c91db14c34f894f4bc48f2300cff1d4 Author: Liao Chang <liaochang1@xxxxxxxxxx> Date: Fri Apr 8 18:09:11 2022 +0800 RISC-V: Add kexec_file support Thanks Dave _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
