Hi Coiby, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/core] [also build test ERROR on v6.7] [cannot apply to linus/master next-20240112] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Coiby-Xu/kexec_file-allow-to-place-kexec_buf-randomly/20240110-151859 base: tip/x86/core patch link: https://lore.kernel.org/r/20240110071522.1308935-3-coxu%40redhat.com patch subject: [PATCH v2 2/5] crash_dump: save the dm crypt key temporarily config: i386-buildonly-randconfig-003-20240113 (https://download.01.org/0day-ci/archive/20240114/202401140034.Sh6fQaK6-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240114/202401140034.Sh6fQaK6-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202401140034.Sh6fQaK6-lkp@xxxxxxxxx/ All error/warnings (new ones prefixed by >>): >> kernel/crash_dump_dm_crypt.c:8:6: warning: no previous prototype for 'wipe_dm_crypt_key' [-Wmissing-prototypes] 8 | void wipe_dm_crypt_key(void) | ^~~~~~~~~~~~~~~~~ kernel/crash_dump_dm_crypt.c: In function 'crash_load_dm_crypt_key': >> kernel/crash_dump_dm_crypt.c:94:16: error: variable 'kbuf' has initializer but incomplete type 94 | struct kexec_buf kbuf = { | ^~~~~~~~~ >> kernel/crash_dump_dm_crypt.c:95:18: error: 'struct kexec_buf' has no member named 'image' 95 | .image = image, | ^~~~~ >> kernel/crash_dump_dm_crypt.c:95:26: warning: excess elements in struct initializer 95 | .image = image, | ^~~~~ kernel/crash_dump_dm_crypt.c:95:26: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:96:18: error: 'struct kexec_buf' has no member named 'buf_min' 96 | .buf_min = 0, | ^~~~~~~ kernel/crash_dump_dm_crypt.c:96:28: warning: excess elements in struct initializer 96 | .buf_min = 0, | ^ kernel/crash_dump_dm_crypt.c:96:28: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:97:18: error: 'struct kexec_buf' has no member named 'buf_max' 97 | .buf_max = ULONG_MAX, | ^~~~~~~ In file included from include/linux/limits.h:7, from include/linux/kernel.h:17, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/nospec-branch.h:14, from arch/x86/include/asm/irqflags.h:9, from include/linux/irqflags.h:17, from include/linux/rcupdate.h:26, from include/linux/rbtree.h:24, from include/linux/key.h:15, from include/keys/user-type.h:11, from kernel/crash_dump_dm_crypt.c:2: >> include/vdso/limits.h:13:25: warning: excess elements in struct initializer 13 | #define ULONG_MAX (~0UL) | ^ kernel/crash_dump_dm_crypt.c:97:28: note: in expansion of macro 'ULONG_MAX' 97 | .buf_max = ULONG_MAX, | ^~~~~~~~~ include/vdso/limits.h:13:25: note: (near initialization for 'kbuf') 13 | #define ULONG_MAX (~0UL) | ^ kernel/crash_dump_dm_crypt.c:97:28: note: in expansion of macro 'ULONG_MAX' 97 | .buf_max = ULONG_MAX, | ^~~~~~~~~ >> kernel/crash_dump_dm_crypt.c:98:18: error: 'struct kexec_buf' has no member named 'top_down' 98 | .top_down = false, | ^~~~~~~~ kernel/crash_dump_dm_crypt.c:98:29: warning: excess elements in struct initializer 98 | .top_down = false, | ^~~~~ kernel/crash_dump_dm_crypt.c:98:29: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:99:18: error: 'struct kexec_buf' has no member named 'random' 99 | .random = true, | ^~~~~~ kernel/crash_dump_dm_crypt.c:99:27: warning: excess elements in struct initializer 99 | .random = true, | ^~~~ kernel/crash_dump_dm_crypt.c:99:27: note: (near initialization for 'kbuf') >> kernel/crash_dump_dm_crypt.c:94:26: error: storage size of 'kbuf' isn't known 94 | struct kexec_buf kbuf = { | ^~~~ >> kernel/crash_dump_dm_crypt.c:109:20: error: 'KEXEC_BUF_MEM_UNKNOWN' undeclared (first use in this function) 109 | kbuf.mem = KEXEC_BUF_MEM_UNKNOWN; | ^~~~~~~~~~~~~~~~~~~~~ kernel/crash_dump_dm_crypt.c:109:20: note: each undeclared identifier is reported only once for each function it appears in >> kernel/crash_dump_dm_crypt.c:110:15: error: implicit declaration of function 'kexec_add_buffer' [-Werror=implicit-function-declaration] 110 | ret = kexec_add_buffer(&kbuf); | ^~~~~~~~~~~~~~~~ >> kernel/crash_dump_dm_crypt.c:94:26: warning: unused variable 'kbuf' [-Wunused-variable] 94 | struct kexec_buf kbuf = { | ^~~~ cc1: some warnings being treated as errors vim +/kbuf +94 kernel/crash_dump_dm_crypt.c 7 > 8 void wipe_dm_crypt_key(void) 9 { 10 if (dm_crypt_key) { 11 memset(dm_crypt_key, 0, dm_crypt_key_size * sizeof(u8)); 12 kfree(dm_crypt_key); 13 dm_crypt_key = NULL; 14 } 15 } 16 17 static void _wipe_dm_crypt_key(struct work_struct *dummy) 18 { 19 wipe_dm_crypt_key(); 20 } 21 22 static DECLARE_DELAYED_WORK(wipe_dm_crypt_key_work, _wipe_dm_crypt_key); 23 24 static unsigned __read_mostly wipe_key_delay = 120; /* 2 mins */ 25 26 static int crash_save_temp_dm_crypt_key(const char *key_desc, size_t count) 27 { 28 const struct user_key_payload *ukp; 29 struct key *key; 30 31 if (dm_crypt_key) { 32 memset(dm_crypt_key, 0, dm_crypt_key_size * sizeof(u8)); 33 kfree(dm_crypt_key); 34 } 35 36 pr_debug("Requesting key %s", key_desc); 37 key = request_key(&key_type_user, key_desc, NULL); 38 39 if (IS_ERR(key)) { 40 pr_debug("No such key %s", key_desc); 41 return PTR_ERR(key); 42 } 43 44 ukp = user_key_payload_locked(key); 45 if (!ukp) 46 return -EKEYREVOKED; 47 48 dm_crypt_key = kmalloc(ukp->datalen, GFP_KERNEL); 49 if (!dm_crypt_key) 50 return -ENOMEM; 51 memcpy(dm_crypt_key, ukp->data, ukp->datalen); 52 dm_crypt_key_size = ukp->datalen; 53 pr_debug("dm crypt key (size=%u): %8ph\n", dm_crypt_key_size, dm_crypt_key); 54 schedule_delayed_work(&wipe_dm_crypt_key_work, 55 round_jiffies_relative(wipe_key_delay * HZ)); 56 return 0; 57 } 58 59 int crash_sysfs_dm_crypt_key_write(const char *key_desc, size_t count) 60 { 61 if (!is_kdump_kernel()) 62 return crash_save_temp_dm_crypt_key(key_desc, count); 63 return -EINVAL; 64 } 65 EXPORT_SYMBOL(crash_sysfs_dm_crypt_key_write); 66 67 int crash_pass_temp_dm_crypt_key(void **addr, unsigned long *sz) 68 { 69 unsigned long dm_crypt_key_sz; 70 unsigned char *buf; 71 unsigned int *size_ptr; 72 73 if (!dm_crypt_key) 74 return -EINVAL; 75 76 dm_crypt_key_sz = sizeof(unsigned int) + dm_crypt_key_size * sizeof(u8); 77 78 buf = vzalloc(dm_crypt_key_sz); 79 if (!buf) 80 return -ENOMEM; 81 82 size_ptr = (unsigned int *)buf; 83 memcpy(size_ptr, &dm_crypt_key_size, sizeof(unsigned int)); 84 memcpy(size_ptr + 1, dm_crypt_key, dm_crypt_key_size * sizeof(u8)); 85 *addr = buf; 86 *sz = dm_crypt_key_sz; 87 wipe_dm_crypt_key(); 88 return 0; 89 } 90 91 int crash_load_dm_crypt_key(struct kimage *image) 92 { 93 int ret; > 94 struct kexec_buf kbuf = { > 95 .image = image, > 96 .buf_min = 0, > 97 .buf_max = ULONG_MAX, > 98 .top_down = false, > 99 .random = true, 100 }; 101 102 image->dm_crypt_key_addr = 0; 103 ret = crash_pass_temp_dm_crypt_key(&kbuf.buffer, &kbuf.bufsz); 104 if (ret) 105 return ret; 106 107 kbuf.memsz = kbuf.bufsz; 108 kbuf.buf_align = ELF_CORE_HEADER_ALIGN; > 109 kbuf.mem = KEXEC_BUF_MEM_UNKNOWN; > 110 ret = kexec_add_buffer(&kbuf); -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
