In the current arm64, crashkernel=,high support has been finished after several rounds of posting and careful reviewing. The code in arm64 which parses crashkernel kernel parameters firstly, then reserve memory can be a good example for other ARCH to refer to. Whereas in x86_64, the code mixing crashkernel parameter parsing and memory reserving is twisted, and looks messy. Refactoring the code to make it more readable maintainable is necessary. Here, firstly abstract the crashkernel parameter parsing code into parse_crashkernel() to make it be able to parse crashkernel=,high|low. Then abstract the crashkernel memory reserving code into a generic function reserve_crashkernel_generic(). Finally, in ARCH which crashkernel=,high support is needed, a simple arch_reserve_crashkernel() can be added to call above two functions. This can remove the duplicated implmentation code in each ARCH, like arm64, x86_64 and riscv. I only did testing on x86_64 and arm64 for below cases, haven't tested riscv. If riscv people can help apply the patchset and give it a shot, it would be great. crashkernel=512M,high crashkernel=512M,high crashkernel=256M,low crashkernel=512M,high crashkernel=0M,low crashkernel=0M,high crashkernel=256M,low crashkernel=512M crashkernel=512M@0x4f000000 crashkernel=1G-4G:256M,4G-64G:320M,64G-:576M crashkernel=0M History: v2->v3: - Move crashk_res and crashk_low_res codes into crash_core.c, and add <asm/crash_core.h> including in <linux/crash_core.h>. These two fix compiling error reported by LKP when CONFIG_CRASH_CORE=on while CONFIG_KEXEC_CORE is unset. - Adjust the if-else and return logic in parse_crashkernel() according to Lei's suggestion. - Make riscv use the generic interface to simplify crahskernel reservation code too since crashkernel=,high support has been added into riscv. - Some minor changes suggested by Lei. v1->v2: - Change to add asm/crash_core.h into x86 and arm64 to contain those arch specific macro definitions for generic reservaton. This fixes the compiling error reported by LKP in v1. https://lore.kernel.org/all/202308272150.p3kRkMoF-lkp@xxxxxxxxx/T/#u - Fix a log typo in patch 8, thanks to Samuel. - RFC->v1: https://lore.kernel.org/all/20230619055951.45620-1-bhe@xxxxxxxxxx/T/#u [RFC PATCH 0/4] kdump: add generic functions to simplify crashkernel crashkernel in architecture Dave and Philipp commented the old parse_crashkernel_common() and parse_crashkernel_generic() are quite confusing. In this formal post, I made change to address the concern by unifying all crashkernel parsing into parse_crashkernel(). Baoquan He (9): crash_core.c: remove unnecessary parameter of function crash_core: change the prototype of function parse_crashkernel() crash_core: change parse_crashkernel() to support crashkernel=,high|low parsing crash_core: add generic function to do reservation crash_core: move crashk_*res definition into crash_core.c x86: kdump: use generic interface to simplify crashkernel reservation code arm64: kdump: use generic interface to simplify crashkernel reservation riscv: kdump: use generic interface to simplify crashkernel reservation crash_core.c: remove unneeded functions arch/arm/kernel/setup.c | 3 +- arch/arm64/Kconfig | 3 + arch/arm64/include/asm/crash_core.h | 10 ++ arch/arm64/mm/init.c | 140 ++------------------ arch/ia64/kernel/setup.c | 2 +- arch/loongarch/kernel/setup.c | 4 +- arch/mips/kernel/setup.c | 3 +- arch/powerpc/kernel/fadump.c | 2 +- arch/powerpc/kexec/core.c | 2 +- arch/powerpc/mm/nohash/kaslr_booke.c | 2 +- arch/riscv/Kconfig | 3 + arch/riscv/include/asm/crash_core.h | 11 ++ arch/riscv/include/asm/processor.h | 2 + arch/riscv/mm/init.c | 141 ++------------------ arch/s390/kernel/setup.c | 4 +- arch/sh/kernel/machine_kexec.c | 2 +- arch/x86/Kconfig | 3 + arch/x86/include/asm/crash_core.h | 34 +++++ arch/x86/kernel/setup.c | 143 +++------------------ include/linux/crash_core.h | 49 ++++++- include/linux/kexec.h | 4 - kernel/crash_core.c | 184 ++++++++++++++++++++++++--- kernel/kexec_core.c | 17 --- 23 files changed, 321 insertions(+), 447 deletions(-) create mode 100644 arch/arm64/include/asm/crash_core.h create mode 100644 arch/riscv/include/asm/crash_core.h create mode 100644 arch/x86/include/asm/crash_core.h -- 2.41.0 _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
