On Thu, 2023-08-31 at 11:59 +0300, Andy Shevchenko wrote: > On Wed, Aug 30, 2023 at 10:15 PM <pstanner@xxxxxxxxxx> wrote: > > On Wed, 2023-08-30 at 17:29 +0300, Andy Shevchenko wrote: > > > On Wed, Aug 30, 2023 at 5:19 PM <pstanner@xxxxxxxxxx> wrote: > > > > On Wed, 2023-08-30 at 17:11 +0300, Andy Shevchenko wrote: > > > > > On Wed, Aug 30, 2023 at 4:46 PM Philipp Stanner > > > > > <pstanner@xxxxxxxxxx> > > > Alphabetical. > > > > > > compiler.h > > > err.h > > > overflow.h > > > ...the rest that is a bit unordered... > > > > > > > > > #include <linux/stdarg.h> > > > > > > #include <uapi/linux/string.h> > > > > I mean I could include my own in a sorted manner – but the existing > > ones are not sorted: > > I know, that's why I put "(to some extent)" in my initial comment. > > > We could sort them all, but I'd prefer to do that in a separate > > patch > > so that this commit does not make the impression of doing anything > > else > > than including the two new headers > > But you can do your stuff first with better ordering than you > proposed > initially, so there will be less churn for any additional change > (either that simply unifies the thing or something else). > > I'll take care of those points in a v2 once I gathered some more feedback from the other parties. P. _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
