On Sun 07-05-23 18:17:13, Luis Chamberlain wrote: > Provide helpers so that we can check a superblock frozen state. > This will make subsequent changes easier to read. This makes > no functional changes. > > Reviewed-by: Jan Kara <jack@xxxxxxx> > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx> Just noticed one nit... > diff --git a/fs/super.c b/fs/super.c > index 0e9d48846684..46c6475fc765 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -905,7 +905,7 @@ int reconfigure_super(struct fs_context *fc) > > if (fc->sb_flags_mask & ~MS_RMT_MASK) > return -EINVAL; > - if (sb->s_writers.frozen != SB_UNFROZEN) > + if (!(sb_is_unfrozen(sb))) ^ unneeded parenthesis here Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec