On Sat, May 6, 2023 at 6:38 AM Jeremy Linton <jeremy.linton@xxxxxxx> wrote: > > On 5/4/23 21:54, Pingfan Liu wrote: > > As more complicated capsule kernel format occurs like zboot, where the > > compressed kernel is stored as a payload. The straight forward > > decompression can not meet the demand. > > > > As the first step, on aarch64, reading in the kernel file in a probe > > method and decide how to unfold the content by the method itself. > > > > The new designed probe interface returns two factors: > > 1. the parsed kernel_buf should be returned so that it can be used by > > the image load method later. > > 2. the final fd passed to sys_kexec_file_load, since aarch64 kernel can > > only work with Image format, the outer payload should be stripped and a > > temporary file of Image should be created. > > > > Well this is unfortunate. I pinged you a few days back but I guess it > must have gotten lost in the noise. > Sorry for that. > I'm ok with dropping my set, but I don't see your 5/5, and it doesn't > show up in the archive either. Which presumably is the core ZBOOT > functionality. From what I can tell without that, this set then is all > just cleanup. So did you do that on purpose, if so maybe its best then > to just rebase on top of my set? > I forgot to add the CC in that patch, and it turns out to be sent to myself only. I have re-sent it. I am happy to rebase on your set with some adaptation to the new probe interface. > > Given I'm not a regular contributor here I'm not sure my opinion matters > much, but one of the things that bothered me when I was yak shaving my > set, were the #ifdef aarch64 bits in the common code. I considered > attempting to remove it but that was a bit more involved than I wanted > to get. But, as Ard correctly points out, the zboot is being used by > more than aarch64 at this point. So that is also a argument for assuring > whatever the probe()/etc interface is, that its not #ifdefed. > Yes, it makes code look not neat. I have tried to tackle it with sed, but failed. I will try to achieve it with coccinelle. Thanks, Pingfan _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
