On 09/08/22 at 01:03am, cgel.zte@xxxxxxxxx wrote:
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Return the value kimage_add_entry() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>
LGTM,
Acked-by: Baoquan He <bhe@xxxxxxxxxx>
> ---
> kernel/kexec_core.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index ca2743f9c634..969e8f52f7da 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -561,23 +561,17 @@ static int kimage_add_entry(struct kimage *image, kimage_entry_t entry)
> static int kimage_set_destination(struct kimage *image,
> unsigned long destination)
> {
> - int result;
> -
> destination &= PAGE_MASK;
> - result = kimage_add_entry(image, destination | IND_DESTINATION);
>
> - return result;
> + return kimage_add_entry(image, destination | IND_DESTINATION);
> }
>
>
> static int kimage_add_page(struct kimage *image, unsigned long page)
> {
> - int result;
> -
> page &= PAGE_MASK;
> - result = kimage_add_entry(image, page | IND_SOURCE);
>
> - return result;
> + return kimage_add_entry(image, page | IND_SOURCE);
> }
>
>
> --
> 2.25.1
>
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
