On 2022/09/27 18:13, dietmar.hahn@xxxxxxxxxxx wrote: > From: HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@xxxxxxx> wrote Tuesday, September 27, 2022 9:58 AM >> >> On 2022/09/26 16:24, dietmar.hahn@xxxxxxxxxxx wrote: >>> Hi, >>> I have a Linux-dom0 running with Xen. The extraction of the vmcore via >>> makdumpfile shows the message: >>> get_xen_basic_info_x86_64: Can't get the symbol of xenheap_phys_end. >>> >>> The commit 2651d571 changed the behaviour of init_xen_crash_info(). >>> With >>> - return TRUE; >>> + ret = TRUE; >>> + >>> +out_error: >>> + free(buf); >>> the buffer is released but it's still used because of >>> info->xen_crash_info.com = buf; >>> This leads to random data in the buffer and later to the mentioned >>> error. >> >> Thank you for the report and patch, I missed that at review completely.. >> >>> >>> With the change back the memory is not released. >>> But I'm not familiar enough with code to decide where to do this. >> >> I've tweaked the patch, does this work for you? > > Yes, much better. > My test cases are working. Thanks for testing, applied. https://github.com/makedumpfile/makedumpfile/commit/a2136943b1f173d2bf7efffc29542556e38aa564 Thanks, Kazu _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
