Re: [PATCH kexec-tools] m68k: pass rng seed via BI_VIRT_RNG_SEED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Fri, Sep 23, 2022 at 3:07 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> This won't work as expected: BI_VIRT_* tags are only valid if the
> machine type is MACH_VIRT.
> Worse, this will trigger for other platform-specific tags using the same value:
> Likewise, this will destroy existing BI_AMIGA_CHIPSET and BI_MAC_SCCBASE
> tags, breaking Amiga and Mac.
> As random seeds can now be generic, I think it makes sense to introduce
> a machine-independent BI_RND_SEED.
> In hindsight, we should have done this from the beginning...

Yes, I agree. I thought that would be rejected, though, which is why I
didn't do that before. I'll send a patch switching over to that.
There's no point in keeping the old one around, I don't think, so I'll
just move everything over to the new.

Jason

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux