Re: [PATCH] vmcoreinfo: add kallsyms_num_syms symbol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew,

I just wanted to check on the status of this. I got your email about it being added to mm-hotfixes-unstable, and I do still see it in the quilt patches set:

https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/vmcoreinfo-add-kallsyms_num_syms-symbol.patch

I see the patch in mm-everything-2022-08-15-02-47 but it seems to have dropped out in mm-everything-2022-08-17-20-59 and later tags. As a result, it no longer shows up in linux-next.

Please excuse me if I'm ignorant of part of your process here, I know you handle a huge volume of patches!

Thanks,
Stephen

On 8/8/22 13:54, Stephen Brennan wrote:
The rest of the kallsyms symbols are useless without knowing the number
of symbols in the table. In an earlier patch, I somehow dropped the
kallsyms_num_syms symbol, so add it back in.

Fixes: 5fd8fea935a1 ("vmcoreinfo: include kallsyms symbols")

Signed-off-by: Stephen Brennan <stephen.s.brennan@xxxxxxxxxx>
---
Hi Baoquan & Andrew,

I made a silly omission in the above mentioned commit, which just got merged
via Andrew's non-mm pull request yesterday. I must have dropped it as I
cherry-picked between versions. Would you be able to queue this up with whatever
fixes you'll send for the 6.0 rc's?

Thanks, and sorry!
Stephen

  kernel/crash_core.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/kernel/crash_core.c b/kernel/crash_core.c
index 07b26df453a9..a0eb4d5cf557 100644
--- a/kernel/crash_core.c
+++ b/kernel/crash_core.c
@@ -494,6 +494,7 @@ static int __init crash_save_vmcoreinfo_init(void)
#ifdef CONFIG_KALLSYMS
  	VMCOREINFO_SYMBOL(kallsyms_names);
+	VMCOREINFO_SYMBOL(kallsyms_num_syms);
  	VMCOREINFO_SYMBOL(kallsyms_token_table);
  	VMCOREINFO_SYMBOL(kallsyms_token_index);
  #ifdef CONFIG_KALLSYMS_BASE_RELATIVE

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux