Andrew Morton wrote:
On Fri, 20 May 2022 14:25:05 -0500 "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> wrote:
> I am not strongly against taking off __weak, just wondering if there's
> chance to fix it in recordmcount, and the cost comparing with kernel fix;
> except of this issue, any other weakness of __weak. Noticed Andrew has
> picked this patch, as a witness of this moment, raise a tiny concern.
I just don't see what else we can realistically do.
I think converting all of the kexec __weaks to use the ifdef approach
makes sense, if only because kexec is now using two different styles.
But for now, I'll send Naveen's v2 patch in to Linus to get us out of
trouble.
Thanks!
I'm thinking that we should add cc:stable to that patch as well, to
reduce the amount of problems which people experience when using newer
binutils on older kernels?
Yes, please. I missed tagging this for stable. It looks like this is
applicable all the way back to v4.9 (though I haven't tested if
recordmcount fails in the same manner with those older kernel levels). I
will post backports once this gets into linus' tree.
- Naveen
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
