Re: [PATCH 17/30] tracing: Improve panic/die notifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx>
Subject: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
From: Steven Rostedt <rostedt@xxxxxxxxxxx>
Date: Fri, 29 Apr 2022 09:23:51 -0400
Cc: linux-hyperv@xxxxxxxxxxxxxxx, halves@xxxxxxxxxxxxx, linux-xtensa@xxxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, alejandro.j.jimenez@xxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, feng.tang@xxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, hidehiro.kawai.ez@xxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, will@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, mikelley@xxxxxxxxxxxxx, john.ogness@xxxxxxxxxxxxx, bhe@xxxxxxxxxx, corbet@xxxxxxx, paulmck@xxxxxxxxxx, fabiomirmar@xxxxxxxxx, x86@xxxxxxxxxx, mingo@xxxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, dyoung@xxxxxxxxxx, vgoyal@xxxxxxxxxx, pmladek@xxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, keescook@xxxxxxxxxxxx, arnd@xxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, coresight@xxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, rcu@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, bp@xxxxxxxxx, luto@xxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, openipmi-developer@xxxxxxxxxxxxxxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, senozhatsky@xxxxxxxxxxxx, vkuznets@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-edac@xxxxxxxxxxxxxxx, jgross@xxxxxxxx, linux-parisc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kernel@xxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, stern@xxxxxxxxxxxxxxxxxxx, d.hatayama@xxxxxxxxxxxxxx, mhiramat@xxxxxxxxxx, kernel-dev@xxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx
In-reply-to: <b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>
References: <20220427224924.592546-1-gpiccoli@igalia.com> <20220427224924.592546-18-gpiccoli@igalia.com> <b8771b37-01f5-f50b-dbb3-9db4ee26e67e@gmail.com>

On Fri, 29 Apr 2022 12:22:44 +0300
Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> wrote:

> > +	switch (ev) {
> > +	case DIE_OOPS:
> > +		do_dump = 1;
> > +		break;
> > +	case PANIC_NOTIFIER:
> > +		do_dump = 1;
> > +		break;  
> 
>    Why not:
> 
> 	case DIE_OOPS:
> 	case PANIC_NOTIFIER:
> 		do_dump = 1;
> 		break;

Agreed.

Other than that.

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec

Follow-Ups:
- Re: [PATCH 17/30] tracing: Improve panic/die notifiers
  - From: Guilherme G. Piccoli

References:
- [PATCH 00/30] The panic notifiers refactor
  - From: Guilherme G. Piccoli
- [PATCH 17/30] tracing: Improve panic/die notifiers
  - From: Guilherme G. Piccoli
- Re: [PATCH 17/30] tracing: Improve panic/die notifiers
  - From: Sergei Shtylyov

Prev by Date: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Next by Date: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Previous by thread: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Next by thread: Re: [PATCH 17/30] tracing: Improve panic/die notifiers
Index(es):
- Date
- Thread

[Index of Archives] [LM Sensors] [Linux Sound] [ALSA Users] [ALSA Devel] [Linux Audio Users] [Linux Media] [Kernel] [Gimp] [Yosemite News] [Linux Media]