On Fri, Jan 21, 2022 at 09:38:49AM +0800, Pingfan Liu wrote:
> On Fri, Jan 21, 2022 at 2:09 AM Philipp Rudo <prudo@xxxxxxxxxx> wrote:
> >
> > Hi Pingfan,
> >
> > On Tue, 18 Jan 2022 15:48:09 +0800
> > Pingfan Liu <piliu@xxxxxxxxxx> wrote:
> >
> > > After kernel commit 7bc1a0f9e176 ("arm64: mm: use single quantity to
> > > represent the PA to VA translation"), phys_offset can be negative if
> > > running 52-bits kernel on 48-bits hardware.
> > >
> > > So changing phys_offset from unsigned to signed.
> > >
> > > Signed-off-by: Pingfan Liu <piliu@xxxxxxxxxx>
> > > Cc: Kairui Song <kasong@xxxxxxxxxxx>
> > > Cc: Simon Horman <horms@xxxxxxxxxxxx>
> > > Cc: Philipp Rudo <prudo@xxxxxxxxxx>
> > > To: kexec@xxxxxxxxxxxxxxxxxxx
> > > ---
> > > kexec/arch/arm64/kexec-arm64.c | 12 ++++++------
> > > kexec/arch/arm64/kexec-arm64.h | 2 +-
> > > util_lib/elf_info.c | 2 +-
> > > util_lib/include/elf_info.h | 2 +-
> > > 4 files changed, 9 insertions(+), 9 deletions(-)
> > >
> >
> > [...]
> >
> > > diff --git a/kexec/arch/arm64/kexec-arm64.h b/kexec/arch/arm64/kexec-arm64.h
> > > index ed447ac..1844b67 100644
> > > --- a/kexec/arch/arm64/kexec-arm64.h
> > > +++ b/kexec/arch/arm64/kexec-arm64.h
> > > @@ -58,7 +58,7 @@ extern off_t initrd_size;
> > > */
> > >
> > > struct arm64_mem {
> > > - uint64_t phys_offset;
> > > + long phys_offset;
> >
> > I think this one should be int64_t as well.
> >
> Yes, you are right. Thanks for your careful review.
>
> @Simon, could you help to correct it or prefer my V5 to fix it.
I think I can fix this while applying this patchset :)
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
