Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Kirill A. Shutemov" <kirill@xxxxxxxxxxxxx>
Subject: Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
From: Borislav Petkov <bp@xxxxxxxxx>
Date: Tue, 21 Sep 2021 23:27:17 +0200
Cc: Tom Lendacky <thomas.lendacky@xxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-graphics-maintainer@xxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, kexec@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Brijesh Singh <brijesh.singh@xxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Andi Kleen <ak@xxxxxxxxxxxxxxx>, Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>, Tianyu Lan <Tianyu.Lan@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>
In-reply-to: <20210921212059.wwlytlmxoft4cdth@box.shutemov.name>
References: <cover.1631141919.git.thomas.lendacky@amd.com> <367624d43d35d61d5c97a8b289d9ddae223636e9.1631141919.git.thomas.lendacky@amd.com> <20210920192341.maue7db4lcbdn46x@box.shutemov.name> <77df37e1-0496-aed5-fd1d-302180f1edeb@amd.com> <YUoao0LlqQ6+uBrq@zn.tnic> <20210921212059.wwlytlmxoft4cdth@box.shutemov.name>

On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote:
> I still believe calling cc_platform_has() from __startup_64() is totally
> broken as it lacks proper wrapping while accessing global variables.

Well, one of the issues on the AMD side was using boot_cpu_data too
early and the Intel side uses it too. Can you replace those checks with
is_tdx_guest() or whatever was the helper's name which would check
whether the the kernel is running as a TDX guest, and see if that helps?

Thx.

-- 
Regards/Gruss,
    Boris.

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec

Follow-Ups:
- Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
  - From: Kirill A. Shutemov

References:
- [PATCH v3 0/8] Implement generic cc_platform_has() helper function
  - From: Tom Lendacky
- [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
  - From: Tom Lendacky
- Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
  - From: Kirill A. Shutemov
- Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
  - From: Tom Lendacky
- Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
  - From: Borislav Petkov
- Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
  - From: Kirill A. Shutemov

Prev by Date: Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
Next by Date: Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
Previous by thread: Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
Next by thread: Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()
Index(es):
- Date
- Thread

[Index of Archives] [LM Sensors] [Linux Sound] [ALSA Users] [ALSA Devel] [Linux Audio Users] [Linux Media] [Kernel] [Gimp] [Yosemite News] [Linux Media]