RE: [MAKEDUMPFILE PATCH 1/2] Add option to prevent writing the dumpfile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



-----Original Message-----
> Hi Julien,
> 
> Thanks for the patches, and sorry for the late reply..
> 
> -----Original Message-----
> > Add a --dry-run option to run all operations without writing the
> > dump to the output file.
> 
> First, I think makedumpfile should not change its behavior (path checks,
> messages emitted, etc.) and exit code except for writing the dumpfile
> with or without the --dry-run option.  For example with this patch:
> 
>   $ touch dumpfile
>   $ makedumpfile -d 1 vmcore dumpfile --dry-run  --> ok, no problem
>   $ makedumpfile -d 1 vmcore dumpfile            --> error
> 
> This change is a bit strange to me.  So with this premise, commented inline
> and attached a modified patch at end of this email.  Could you check those?

This patchset is applied with some modifications:
https://github.com/makedumpfile/makedumpfile/compare/54aec38...6f3e75a

I will add another for counting bytes to be written and more readable stats later..

Thanks,
Kazu


_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux