On Thu, Sep 17, 2020 at 12:14:02AM +0530, Bhupesh SHARMA wrote: > Hi Youling, > > On Sat, Sep 12, 2020 at 7:10 AM Youling Tang <tangyouling@xxxxxxxxxxx> wrote: > > > > Where Y specifies how much memory to reserve for the dump-capture kernel > > and X specifies the beginning of this reserved memory. So Y should be > > placed before X. > > > > Signed-off-by: Youling Tang <tangyouling@xxxxxxxxxxx> > > --- > > kexec/kexec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kexec/kexec.c b/kexec/kexec.c > > index bb88caa..fd7c8d2 100644 > > --- a/kexec/kexec.c > > +++ b/kexec/kexec.c > > @@ -1530,7 +1530,7 @@ int main(int argc, char *argv[]) > > !is_crashkernel_mem_reserved()) { > > die("Memory for crashkernel is not reserved\n" > > "Please reserve memory by passing" > > - "\"crashkernel=X@Y\" parameter to kernel\n" > > + "\"crashkernel=Y@X\" parameter to kernel\n" > > "Then try to loading kdump kernel\n"); > > } > > > > -- > > 2.1.0 > > Thanks for the patch. LGTM, so: > Reviewed-by: Bhupesh Sharma <bhsharma@xxxxxxxxxx> Thanks, applied. _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec