On Mon, Nov 18, 2019 at 12:52:15PM +1300, Chris Packham wrote:
> This addresses the following compilation issues when building for i386.
>
> kexec/arch/i386/kexec-x86.c:39:22: error: 'multiboot2_x86_probe' undeclared here (not in a function); did you mean 'multiboot_x86_probe'?
> { "multiboot2-x86", multiboot2_x86_probe, multiboot2_x86_load,
> ^~~~~~~~~~~~~~~~~~~~
> multiboot_x86_probe
> kexec/arch/i386/kexec-x86.c:39:44: error: 'multiboot2_x86_load' undeclared here (not in a function); did you mean 'multiboot_x86_load'?
> { "multiboot2-x86", multiboot2_x86_probe, multiboot2_x86_load,
> ^~~~~~~~~~~~~~~~~~~
> multiboot_x86_load
> kexec/arch/i386/kexec-x86.c:40:4: error: 'multiboot2_x86_usage' undeclared here (not in a function); did you mean 'multiboot_x86_usage'?
> multiboot2_x86_usage },
> ^~~~~~~~~~~~~~~~~~~~
> multiboot_x86_usage
> make: *** [Makefile:114: kexec/arch/i386/kexec-x86.o] Error 1
> make: *** Waiting for unfinished jobs....
>
> Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
> I wasn't sure whether this should be fixed by linking with kexec-mb2-x86.o or
> by removing the code from kexec-x86.c. I went for the former but I'd happily
> change to the latter.
>
> kexec/arch/i386/Makefile | 2 +-
> kexec/arch/i386/kexec-x86.h | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
Hi Chris,
sorry for letting this slip through the cracks.
This change looks good to me and I've applied it for inclusion in
the next release of kexec tools.
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
