Hi Pingfan,
> -----Original Message-----
> In refiltering mode, each sub process inherits bitmap2->fd from parent.
> Then they lseek()/read() on the same fd, which means that they interference
> with each other.
>
> This breaks the purpose of SPLITTING_FD_BITMAP(i) for each sub process.
> Fix it by assigning a sub process dedicated fd to bitmap2->fd.
>
> Signed-off-by: Pingfan Liu <piliu@xxxxxxxxxx>
Thanks for the patch.
I'm still reading the code, but it might be better to apply this to bitmap1->fd
as well? see you next week..
Thanks,
Kazu
> ---
> makedumpfile.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/makedumpfile.c b/makedumpfile.c
> index d76a435..1dc8640 100644
> --- a/makedumpfile.c
> +++ b/makedumpfile.c
> @@ -8857,7 +8857,8 @@ write_kdump_pages_and_bitmap_cyclic(struct cache_data *cd_header, struct cache_d
> if (info->flag_cyclic) {
> if (!prepare_bitmap2_buffer())
> return FALSE;
> - }
> + } else if (info->flag_refiltering)
> + info->bitmap2->fd = info->fd_bitmap;
>
> /*
> * Write pages and bitmap cyclically.
> --
> 2.7.5
>
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
