Hi Kazu, On Wed, Dec 4, 2019 at 11:07 PM Kazuhito Hagio <k-hagio@xxxxxxxxxxxxx> wrote: > > > -----Original Message----- > > ARMv8.2-LPA architecture extension (if available on underlying hardware) > > can support 52-bit physical addresses, while the kernel virtual > > addresses remain 48-bit. > > > > Make sure that we read the 52-bit PA address capability from > > 'MAX_PHYSMEM_BITS' variable (if available in vmcoreinfo) and > > accordingly change the pte_to_phy() mask values and also traverse > > the page-table walk accordingly. > > > > Also make sure that it works well for the existing 48-bit PA address > > platforms and also on environments which use newer kernels with 52-bit > > PA support but hardware which is not ARM8.2-LPA compliant. > > > > I have sent a kernel patch upstream to add 'MAX_PHYSMEM_BITS' to > > vmcoreinfo for arm64 (see [0]). > > > > This patch is in accordance with ARMv8 Architecture Reference Manual > > version D.a > > > > [0]. http://lists.infradead.org/pipermail/kexec/2019-November/023960.html > > > > Cc: Kazuhito Hagio <k-hagio@xxxxxxxxxxxxx> > > Cc: John Donnelly <john.p.donnelly@xxxxxxxxxx> > > Cc: kexec@xxxxxxxxxxxxxxxxxxx > > Signed-off-by: Bhupesh Sharma <bhsharma@xxxxxxxxxx> > > --- > > arch/arm64.c | 292 +++++++++++++++++++++++++++++++++++++++++------------------ > > 1 file changed, 204 insertions(+), 88 deletions(-) > > > > diff --git a/arch/arm64.c b/arch/arm64.c > > index 3516b340adfd..ecb19139e178 100644 > > --- a/arch/arm64.c > > +++ b/arch/arm64.c > > @@ -39,72 +39,184 @@ typedef struct { > > unsigned long pte; > > } pte_t; > > > > > +#define __pte(x) ((pte_t) { (x) } ) > > +#define __pmd(x) ((pmd_t) { (x) } ) > > +#define __pud(x) ((pud_t) { (x) } ) > > +#define __pgd(x) ((pgd_t) { (x) } ) > > Is it possible to remove these macros? Ok, will fix in v5. > > + > > +static int lpa_52_bit_support_available; > > static int pgtable_level; > > static int va_bits; > > static unsigned long kimage_voffset; > > > > -#define SZ_4K (4 * 1024) > > -#define SZ_16K (16 * 1024) > > -#define SZ_64K (64 * 1024) > > -#define SZ_128M (128 * 1024 * 1024) > > +#define SZ_4K 4096 > > +#define SZ_16K 16384 > > +#define SZ_64K 65536 > > > > -#define PAGE_OFFSET_36 ((0xffffffffffffffffUL) << 36) > > -#define PAGE_OFFSET_39 ((0xffffffffffffffffUL) << 39) > > -#define PAGE_OFFSET_42 ((0xffffffffffffffffUL) << 42) > > -#define PAGE_OFFSET_47 ((0xffffffffffffffffUL) << 47) > > -#define PAGE_OFFSET_48 ((0xffffffffffffffffUL) << 48) > > +#define PAGE_OFFSET_36 ((0xffffffffffffffffUL) << 36) > > +#define PAGE_OFFSET_39 ((0xffffffffffffffffUL) << 39) > > +#define PAGE_OFFSET_42 ((0xffffffffffffffffUL) << 42) > > +#define PAGE_OFFSET_47 ((0xffffffffffffffffUL) << 47) > > +#define PAGE_OFFSET_48 ((0xffffffffffffffffUL) << 48) > > +#define PAGE_OFFSET_52 ((0xffffffffffffffffUL) << 52) > > > > #define pgd_val(x) ((x).pgd) > > #define pud_val(x) (pgd_val((x).pgd)) > > #define pmd_val(x) (pud_val((x).pud)) > > #define pte_val(x) ((x).pte) > > > > -#define PAGE_MASK (~(PAGESIZE() - 1)) > > -#define PGDIR_SHIFT ((PAGESHIFT() - 3) * pgtable_level + 3) > > -#define PTRS_PER_PGD (1 << (va_bits - PGDIR_SHIFT)) > > -#define PUD_SHIFT get_pud_shift_arm64() > > -#define PUD_SIZE (1UL << PUD_SHIFT) > > -#define PUD_MASK (~(PUD_SIZE - 1)) > > -#define PTRS_PER_PTE (1 << (PAGESHIFT() - 3)) > > -#define PTRS_PER_PUD PTRS_PER_PTE > > -#define PMD_SHIFT ((PAGESHIFT() - 3) * 2 + 3) > > -#define PMD_SIZE (1UL << PMD_SHIFT) > > -#define PMD_MASK (~(PMD_SIZE - 1)) > > > +/* See 'include/uapi/linux/const.h' for definitions below */ > > +#define __AC(X,Y) (X##Y) > > +#define _AC(X,Y) __AC(X,Y) > > +#define _AT(T,X) ((T)(X)) > > + > > +/* See 'include/asm/pgtable-types.h' for definitions below */ > > +typedef unsigned long pteval_t; > > +typedef unsigned long pmdval_t; > > +typedef unsigned long pudval_t; > > +typedef unsigned long pgdval_t; > > Is it possible to remove these macros/typedefs as well? > I don't think they make the code easier to read.. Ok. The idea behind it was to keep the makedumpfile(user-space) page-table-walk code similar to Linux kernel (as much as possible), so that if we identify an issue in user-space code, it is easier to correlate it with the corresponding kernel code. I will try to see how this can be addressed while making the code easier to read/understand. Regards, Bhupesh > > + > > +#define PAGE_SHIFT PAGESHIFT() > > + > > +/* See 'arch/arm64/include/asm/pgtable-hwdef.h' for definitions below */ > > + > > +#define ARM64_HW_PGTABLE_LEVEL_SHIFT(n) ((PAGE_SHIFT - 3) * (4 - (n)) + 3) > > + > > +#define PTRS_PER_PTE (1 << (PAGE_SHIFT - 3)) > > + > > +/* > > + * PMD_SHIFT determines the size a level 2 page table entry can map. > > + */ > > +#define PMD_SHIFT ARM64_HW_PGTABLE_LEVEL_SHIFT(2) > > +#define PMD_SIZE (_AC(1, UL) << PMD_SHIFT) > > +#define PMD_MASK (~(PMD_SIZE-1)) > > #define PTRS_PER_PMD PTRS_PER_PTE > > > > -#define PAGE_PRESENT (1 << 0) > > +/* > > + * PUD_SHIFT determines the size a level 1 page table entry can map. > > + */ > > +#define PUD_SHIFT ARM64_HW_PGTABLE_LEVEL_SHIFT(1) > > +#define PUD_SIZE (_AC(1, UL) << PUD_SHIFT) > > +#define PUD_MASK (~(PUD_SIZE-1)) > > +#define PTRS_PER_PUD PTRS_PER_PTE > > + > > +/* > > + * PGDIR_SHIFT determines the size a top-level page table entry can map > > + * (depending on the configuration, this level can be 0, 1 or 2). > > + */ > > +#define PGDIR_SHIFT ARM64_HW_PGTABLE_LEVEL_SHIFT(4 - (pgtable_level)) > > +#define PGDIR_SIZE (_AC(1, UL) << PGDIR_SHIFT) > > +#define PGDIR_MASK (~(PGDIR_SIZE-1)) > > +#define PTRS_PER_PGD (1 << ((va_bits) - PGDIR_SHIFT)) > > + > > +/* > > + * Section address mask and size definitions. > > + */ > > #define SECTIONS_SIZE_BITS 30 > > -/* Highest possible physical address supported */ > > -#define PHYS_MASK_SHIFT 48 > > -#define PHYS_MASK ((1UL << PHYS_MASK_SHIFT) - 1) > > + > > /* > > - * Remove the highest order bits that are not a part of the > > - * physical address in a section > > + * Hardware page table definitions. > > + * > > + * Level 1 descriptor (PUD). > > */ > > -#define PMD_SECTION_MASK ((1UL << 40) - 1) > > +#define PUD_TYPE_TABLE (_AT(pudval_t, 3) << 0) > > +#define PUD_TABLE_BIT (_AT(pudval_t, 1) << 1) > > +#define PUD_TYPE_MASK (_AT(pudval_t, 3) << 0) > > +#define PUD_TYPE_SECT (_AT(pudval_t, 1) << 0) > > > > -#define PMD_TYPE_MASK 3 > > -#define PMD_TYPE_SECT 1 > > -#define PMD_TYPE_TABLE 3 > > +/* > > + * Level 2 descriptor (PMD). > > + */ > > +#define PMD_TYPE_MASK (_AT(pmdval_t, 3) << 0) > > +#define PMD_TYPE_FAULT (_AT(pmdval_t, 0) << 0) > > +#define PMD_TYPE_TABLE (_AT(pmdval_t, 3) << 0) > > +#define PMD_TYPE_SECT (_AT(pmdval_t, 1) << 0) > > +#define PMD_TABLE_BIT (_AT(pmdval_t, 1) << 1) > > + > > +/* > > + * Level 3 descriptor (PTE). > > + */ > > +#define PTE_ADDR_LOW (((_AT(pteval_t, 1) << (48 - PAGE_SHIFT)) - 1) << PAGE_SHIFT) > > +#define PTE_ADDR_HIGH (_AT(pteval_t, 0xf) << 12) > > + > > +static inline unsigned long > > +get_pte_addr_mask_arm64(void) > > +{ > > + if (lpa_52_bit_support_available) > > + return (PTE_ADDR_LOW | PTE_ADDR_HIGH); > > + else > > + return PTE_ADDR_LOW; > > +} > > + > > +#define PTE_ADDR_MASK get_pte_addr_mask_arm64() > > > > -#define PUD_TYPE_MASK 3 > > -#define PUD_TYPE_SECT 1 > > -#define PUD_TYPE_TABLE 3 > > +#define PAGE_MASK (~(PAGESIZE() - 1)) > > +#define PAGE_PRESENT (1 << 0) > > > > +/* Helper API to convert between a physical address and its placement > > + * in a page table entry, taking care of 52-bit addresses. > > + */ > > +static inline unsigned long > > +__pte_to_phys(pte_t pte) > > +{ > > + if (lpa_52_bit_support_available) > > + return ((pte_val(pte) & PTE_ADDR_LOW) | ((pte_val(pte) & PTE_ADDR_HIGH) << 36)); > > + else > > + return (pte_val(pte) & PTE_ADDR_MASK); > > +} > > + > > +/* Find an entry in a page-table-directory */ > > #define pgd_index(vaddr) (((vaddr) >> PGDIR_SHIFT) & (PTRS_PER_PGD - 1)) > > -#define pgd_offset(pgdir, vaddr) ((pgd_t *)(pgdir) + pgd_index(vaddr)) > > > > -#define pte_index(vaddr) (((vaddr) >> PAGESHIFT()) & (PTRS_PER_PTE - 1)) > > -#define pmd_page_paddr(pmd) (pmd_val(pmd) & PHYS_MASK & (int32_t)PAGE_MASK) > > -#define pte_offset(dir, vaddr) ((pte_t*)pmd_page_paddr((*dir)) + pte_index(vaddr)) > > +static inline pte_t > > +pgd_pte(pgd_t pgd) > > +{ > > + return __pte(pgd_val(pgd)); > > +} > > > > -#define pmd_index(vaddr) (((vaddr) >> PMD_SHIFT) & (PTRS_PER_PMD - 1)) > > -#define pud_page_paddr(pud) (pud_val(pud) & PHYS_MASK & (int32_t)PAGE_MASK) > > -#define pmd_offset_pgtbl_lvl_2(pud, vaddr) ((pmd_t *)pud) > > -#define pmd_offset_pgtbl_lvl_3(pud, vaddr) ((pmd_t *)pud_page_paddr((*pud)) + pmd_index(vaddr)) > > +#define __pgd_to_phys(pgd) __pte_to_phys(pgd_pte(pgd)) > > +#define pgd_offset(pgd, vaddr) ((pgd_t *)(pgd) + pgd_index(vaddr)) > > + > > +static inline pte_t pud_pte(pud_t pud) > > +{ > > + return __pte(pud_val(pud)); > > +} > > > > +static inline unsigned long > > +pgd_page_paddr(pgd_t pgd) > > +{ > > + return __pgd_to_phys(pgd); > > +} > > + > > +/* Find an entry in the first-level page table. */ > > #define pud_index(vaddr) (((vaddr) >> PUD_SHIFT) & (PTRS_PER_PUD - 1)) > > -#define pgd_page_paddr(pgd) (pgd_val(pgd) & PHYS_MASK & (int32_t)PAGE_MASK) > > +#define __pud_to_phys(pud) __pte_to_phys(pud_pte(pud)) > > + > > +static inline unsigned long > > +pud_page_paddr(pud_t pud) > > +{ > > + return __pud_to_phys(pud); > > +} > > + > > +/* Find an entry in the second-level page table. */ > > +#define pmd_index(vaddr) (((vaddr) >> PMD_SHIFT) & (PTRS_PER_PMD - 1)) > > + > > +static inline pte_t pmd_pte(pmd_t pmd) > > +{ > > + return __pte(pmd_val(pmd)); > > +} > > + > > +#define __pmd_to_phys(pmd) __pte_to_phys(pmd_pte(pmd)) > > + > > +static inline unsigned long > > +pmd_page_paddr(pmd_t pmd) > > +{ > > + return __pmd_to_phys(pmd); > > +} > > + > > +/* Find an entry in the third-level page table. */ > > +#define pte_index(vaddr) (((vaddr) >> PAGESHIFT()) & (PTRS_PER_PTE - 1)) > > +#define pte_offset(dir, vaddr) (pmd_page_paddr((*dir)) + pte_index(vaddr) * sizeof(pte_t)) > > > > static unsigned long long > > __pa(unsigned long vaddr) > > @@ -116,32 +228,22 @@ __pa(unsigned long vaddr) > > return (vaddr - kimage_voffset); > > } > > > > -static int > > -get_pud_shift_arm64(void) > > +static pud_t * > > +pud_offset(pgd_t *pgda, pgd_t *pgdv, unsigned long vaddr) > > { > > - if (pgtable_level == 4) > > - return ((PAGESHIFT() - 3) * 3 + 3); > > + if (pgtable_level > 3) > > + return (pud_t *)(pgd_page_paddr(*pgdv) + pud_index(vaddr) * sizeof(pud_t)); > > else > > - return PGDIR_SHIFT; > > + return (pud_t *)(pgda); > > } > > > > static pmd_t * > > pmd_offset(pud_t *puda, pud_t *pudv, unsigned long vaddr) > > { > > - if (pgtable_level == 2) { > > - return pmd_offset_pgtbl_lvl_2(puda, vaddr); > > - } else { > > - return pmd_offset_pgtbl_lvl_3(pudv, vaddr); > > - } > > -} > > - > > -static pud_t * > > -pud_offset(pgd_t *pgda, pgd_t *pgdv, unsigned long vaddr) > > -{ > > - if (pgtable_level == 4) > > - return ((pud_t *)pgd_page_paddr((*pgdv)) + pud_index(vaddr)); > > + if (pgtable_level > 2) > > + return (pmd_t *)(pud_page_paddr(*pudv) + pmd_index(vaddr) * sizeof(pmd_t)); > > else > > - return (pud_t *)(pgda); > > + return (pmd_t*)(puda); > > } > > > > static int calculate_plat_config(void) > > @@ -307,6 +409,14 @@ get_stext_symbol(void) > > int > > get_machdep_info_arm64(void) > > { > > + /* Determine if the PA address range is 52-bits: ARMv8.2-LPA */ > > + if (NUMBER(MAX_PHYSMEM_BITS) != NOT_FOUND_NUMBER) { > > + info->max_physmem_bits = NUMBER(MAX_PHYSMEM_BITS); > > + if (info->max_physmem_bits == 52) > > + lpa_52_bit_support_available = 1; > > + } else > > + info->max_physmem_bits = 48; > > + > > /* Check if va_bits is still not initialized. If still 0, call > > * get_versiondep_info() to initialize the same. > > */ > > @@ -319,12 +429,11 @@ get_machdep_info_arm64(void) > > } > > > > kimage_voffset = NUMBER(kimage_voffset); > > - info->max_physmem_bits = PHYS_MASK_SHIFT; > > info->section_size_bits = SECTIONS_SIZE_BITS; > > > > DEBUG_MSG("kimage_voffset : %lx\n", kimage_voffset); > > - DEBUG_MSG("max_physmem_bits : %lx\n", info->max_physmem_bits); > > - DEBUG_MSG("section_size_bits: %lx\n", info->section_size_bits); > > + DEBUG_MSG("max_physmem_bits : %ld\n", info->max_physmem_bits); > > + DEBUG_MSG("section_size_bits: %ld\n", info->section_size_bits); > > > > return TRUE; > > } > > @@ -382,6 +491,19 @@ get_versiondep_info_arm64(void) > > return TRUE; > > } > > > > +/* 1GB section for Page Table level = 4 and Page Size = 4KB */ > > +static int > > +is_pud_sect(pud_t pud) > > +{ > > + return ((pud_val(pud) & PUD_TYPE_MASK) == PUD_TYPE_SECT); > > +} > > + > > +static int > > +is_pmd_sect(pmd_t pmd) > > +{ > > + return ((pmd_val(pmd) & PMD_TYPE_MASK) == PMD_TYPE_SECT); > > +} > > + > > /* > > * vaddr_to_paddr_arm64() - translate arbitrary virtual address to physical > > * @vaddr: virtual address to translate > > @@ -419,10 +541,9 @@ vaddr_to_paddr_arm64(unsigned long vaddr) > > return NOT_PADDR; > > } > > > > - if ((pud_val(pudv) & PUD_TYPE_MASK) == PUD_TYPE_SECT) { > > - /* 1GB section for Page Table level = 4 and Page Size = 4KB */ > > - paddr = (pud_val(pudv) & (PUD_MASK & PMD_SECTION_MASK)) > > - + (vaddr & (PUD_SIZE - 1)); > > + if (is_pud_sect(pudv)) { > > + paddr = (pud_page_paddr(pudv) & PUD_MASK) + > > + (vaddr & (PUD_SIZE - 1)); > > return paddr; > > } > > > > @@ -432,29 +553,24 @@ vaddr_to_paddr_arm64(unsigned long vaddr) > > return NOT_PADDR; > > } > > > > - switch (pmd_val(pmdv) & PMD_TYPE_MASK) { > > - case PMD_TYPE_TABLE: > > - ptea = pte_offset(&pmdv, vaddr); > > - /* 64k page */ > > - if (!readmem(PADDR, (unsigned long long)ptea, &ptev, sizeof(ptev))) { > > - ERRMSG("Can't read pte\n"); > > - return NOT_PADDR; > > - } > > + if (is_pmd_sect(pmdv)) { > > + paddr = (pmd_page_paddr(pmdv) & PMD_MASK) + > > + (vaddr & (PMD_SIZE - 1)); > > + return paddr; > > + } > > > > - if (!(pte_val(ptev) & PAGE_PRESENT)) { > > - ERRMSG("Can't get a valid pte.\n"); > > - return NOT_PADDR; > > - } else { > > + ptea = (pte_t *)pte_offset(&pmdv, vaddr); > > + if (!readmem(PADDR, (unsigned long long)ptea, &ptev, sizeof(ptev))) { > > + ERRMSG("Can't read pte\n"); > > + return NOT_PADDR; > > + } > > > > - paddr = (PAGEBASE(pte_val(ptev)) & PHYS_MASK) > > - + (vaddr & (PAGESIZE() - 1)); > > - } > > - break; > > - case PMD_TYPE_SECT: > > - /* 512MB section for Page Table level = 3 and Page Size = 64KB*/ > > - paddr = (pmd_val(pmdv) & (PMD_MASK & PMD_SECTION_MASK)) > > - + (vaddr & (PMD_SIZE - 1)); > > - break; > > + if (!(pte_val(ptev) & PAGE_PRESENT)) { > > + ERRMSG("Can't get a valid pte.\n"); > > + return NOT_PADDR; > > + } else { > > + paddr = __pte_to_phys(ptev) + > > + (vaddr & (PAGESIZE() - 1)); > > } > > > > return paddr; > > -- > > 2.7.4 > > > > > > _______________________________________________ > kexec mailing list > kexec@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/kexec > _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
