On Thu, Oct 31, 2019 at 05:40:35PM +0800, lijiang wrote:
> Maybe it should be a separate patch to fix the old compile warnings as follow.
> And i should put the patch into this series.
Yes, maybe.
> commit d2091d1f4f67f1c38293b0e93fdbfefa766940cf (HEAD -> master)
> Author: Lianbo Jiang <lijiang@xxxxxxxxxx>
> Date: Thu Oct 31 15:48:02 2019 +0800
>
> kexec: Fix i386 build warnings that missed declaration of struct kimage
>
> Kbuild test robot reported some build warnings, please refer to the
> Link below for details.
Explain here what the warnings are, why they trigger and how you're
fixing it. How a commit message should look like is also explained in
that document I pointed you at.
Refering to some link is not what we do in commit messages.
> Add a declaration of struct kimage to fix these compile warnings.
>
> Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Lianbo Jiang <lijiang@xxxxxxxxxx>
> Link: https://lkml.org/lkml/2019/10/30/833
*NEVER* use lkml.org or any other external URL for refering to mail
threads but *always* use our own
lkml.kernel.org/r/<Message-ID>
redirector. See other tip commits for an example.
> > You can read
> >
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >
> > in the meantime, especially section
> >
> > "9) Don't get discouraged - or impatient"
> >
> > while waiting.
>
> OK. Thanks.
And make sure to read that whole document and also have a look at the
process document
https://www.kernel.org/doc/html/latest/process/index.html
so that you can avoid such mistakes in the future.
Thx.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec
