On Tue, Sep 10, 2019 at 7:25 PM lijiang <lijiang@xxxxxxxxxx> wrote: > > 在 2019年09月10日 18:21, Bhupesh Sharma 写道: > > Running 'cppcheck' static code analyzer (see cppcheck(1)) > > on 'vmcore-dmesg/vmcore-dmesg.c' shows the following > > shifting error: > > > > $ cppcheck --enable=all vmcore-dmesg/vmcore-dmesg.c > > Checking vmcore-dmesg/vmcore-dmesg.c ... > > [vmcore-dmesg/vmcore-dmesg.c:17]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour > > > > Fix the same via this patch. > > > > Cc: Lianbo Jiang <lijiang@xxxxxxxxxx> > > Cc: Simon Horman <horms@xxxxxxxxxxxx> > > Signed-off-by: Bhupesh Sharma <bhsharma@xxxxxxxxxx> > > --- > > vmcore-dmesg/vmcore-dmesg.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c > > index 81c2a58..122e536 100644 > > --- a/vmcore-dmesg/vmcore-dmesg.c > > +++ b/vmcore-dmesg/vmcore-dmesg.c > > @@ -6,7 +6,7 @@ typedef Elf32_Nhdr Elf_Nhdr; > > extern const char *fname; > > > > /* stole this macro from kernel printk.c */ > > -#define LOG_BUF_LEN_MAX (uint32_t)(1 << 31) > > +#define LOG_BUF_LEN_MAX (uint32_t)(1U << 31) > > > > This looks better. Thank you, Bhupesh. Thanks for your review, Lianbo. Regards, Bhupesh _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
