Re: [PATCH v6 1/4] x86: kdump: move reserve_crashkernel_low() into crash_core.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chen-Zhou/support-reserving-crashkernel-above-4G-on-arm64-kdump/20190901-053351
config: um-i386_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=um SUBARCH=i386

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from include/linux/crash_core.h:9:0,
                    from kernel//printk/printk.c:37:
   arch/x86/include/asm/kexec.h: In function 'crash_setup_regs':
   arch/x86/include/asm/kexec.h:88:46: error: 'struct pt_regs' has no member named 'bx'
      asm volatile("movl %%ebx,%0" : "=m"(newregs->bx));
                                                 ^~
   arch/x86/include/asm/kexec.h:89:46: error: 'struct pt_regs' has no member named 'cx'
      asm volatile("movl %%ecx,%0" : "=m"(newregs->cx));
                                                 ^~
   arch/x86/include/asm/kexec.h:90:46: error: 'struct pt_regs' has no member named 'dx'
      asm volatile("movl %%edx,%0" : "=m"(newregs->dx));
                                                 ^~
   arch/x86/include/asm/kexec.h:91:46: error: 'struct pt_regs' has no member named 'si'
      asm volatile("movl %%esi,%0" : "=m"(newregs->si));
                                                 ^~
   arch/x86/include/asm/kexec.h:92:46: error: 'struct pt_regs' has no member named 'di'
      asm volatile("movl %%edi,%0" : "=m"(newregs->di));
                                                 ^~
   arch/x86/include/asm/kexec.h:93:46: error: 'struct pt_regs' has no member named 'bp'
      asm volatile("movl %%ebp,%0" : "=m"(newregs->bp));
                                                 ^~
   arch/x86/include/asm/kexec.h:94:46: error: 'struct pt_regs' has no member named 'ax'
      asm volatile("movl %%eax,%0" : "=m"(newregs->ax));
                                                 ^~
   arch/x86/include/asm/kexec.h:95:46: error: 'struct pt_regs' has no member named 'sp'
      asm volatile("movl %%esp,%0" : "=m"(newregs->sp));
                                                 ^~
   arch/x86/include/asm/kexec.h:96:49: error: 'struct pt_regs' has no member named 'ss'
      asm volatile("movl %%ss, %%eax;" :"=a"(newregs->ss));
                                                    ^~
   arch/x86/include/asm/kexec.h:97:49: error: 'struct pt_regs' has no member named 'cs'
      asm volatile("movl %%cs, %%eax;" :"=a"(newregs->cs));
                                                    ^~
>> arch/x86/include/asm/kexec.h:98:49: error: 'struct pt_regs' has no member named 'ds'
      asm volatile("movl %%ds, %%eax;" :"=a"(newregs->ds));
                                                    ^~
>> arch/x86/include/asm/kexec.h:99:51: error: 'struct pt_regs' has no member named 'es'; did you mean 'regs'?
      asm volatile("movl %%es, %%eax;" :"=a"(newregs->es));
                                                      ^~
                                                      regs
   arch/x86/include/asm/kexec.h:100:47: error: 'struct pt_regs' has no member named 'flags'
      asm volatile("pushfl; popl %0" :"=m"(newregs->flags));
                                                  ^~
   arch/x86/include/asm/kexec.h:122:10: error: 'struct pt_regs' has no member named 'ip'
      newregs->ip = _THIS_IP_;
             ^~

vim +98 arch/x86/include/asm/kexec.h

dd5f726076cc76 arch/x86/include/asm/kexec.h Vivek Goyal      2014-08-08   75  
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   76  /*
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   77   * This function is responsible for capturing register states if coming
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   78   * via panic otherwise just fix up the ss and sp if coming via kernel
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   79   * mode exception.
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   80   */
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   81  static inline void crash_setup_regs(struct pt_regs *newregs,
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   82  				    struct pt_regs *oldregs)
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   83  {
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   84  	if (oldregs) {
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   85  		memcpy(newregs, oldregs, sizeof(*newregs));
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   86  	} else {
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30   87  #ifdef CONFIG_X86_32
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   88  		asm volatile("movl %%ebx,%0" : "=m"(newregs->bx));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   89  		asm volatile("movl %%ecx,%0" : "=m"(newregs->cx));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   90  		asm volatile("movl %%edx,%0" : "=m"(newregs->dx));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   91  		asm volatile("movl %%esi,%0" : "=m"(newregs->si));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   92  		asm volatile("movl %%edi,%0" : "=m"(newregs->di));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   93  		asm volatile("movl %%ebp,%0" : "=m"(newregs->bp));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   94  		asm volatile("movl %%eax,%0" : "=m"(newregs->ax));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  @95  		asm volatile("movl %%esp,%0" : "=m"(newregs->sp));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  @96  		asm volatile("movl %%ss, %%eax;" :"=a"(newregs->ss));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23   97  		asm volatile("movl %%cs, %%eax;" :"=a"(newregs->cs));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  @98  		asm volatile("movl %%ds, %%eax;" :"=a"(newregs->ds));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  @99  		asm volatile("movl %%es, %%eax;" :"=a"(newregs->es));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  100  		asm volatile("pushfl; popl %0" :"=m"(newregs->flags));
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30  101  #else
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  102  		asm volatile("movq %%rbx,%0" : "=m"(newregs->bx));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  103  		asm volatile("movq %%rcx,%0" : "=m"(newregs->cx));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  104  		asm volatile("movq %%rdx,%0" : "=m"(newregs->dx));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  105  		asm volatile("movq %%rsi,%0" : "=m"(newregs->si));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  106  		asm volatile("movq %%rdi,%0" : "=m"(newregs->di));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  107  		asm volatile("movq %%rbp,%0" : "=m"(newregs->bp));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  108  		asm volatile("movq %%rax,%0" : "=m"(newregs->ax));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  109  		asm volatile("movq %%rsp,%0" : "=m"(newregs->sp));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  110  		asm volatile("movq %%r8,%0" : "=m"(newregs->r8));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  111  		asm volatile("movq %%r9,%0" : "=m"(newregs->r9));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  112  		asm volatile("movq %%r10,%0" : "=m"(newregs->r10));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  113  		asm volatile("movq %%r11,%0" : "=m"(newregs->r11));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  114  		asm volatile("movq %%r12,%0" : "=m"(newregs->r12));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  115  		asm volatile("movq %%r13,%0" : "=m"(newregs->r13));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  116  		asm volatile("movq %%r14,%0" : "=m"(newregs->r14));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  117  		asm volatile("movq %%r15,%0" : "=m"(newregs->r15));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  118  		asm volatile("movl %%ss, %%eax;" :"=a"(newregs->ss));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  119  		asm volatile("movl %%cs, %%eax;" :"=a"(newregs->cs));
b69a3f9dc0bbdb include/asm-x86/kexec.h      Joe Perches      2008-03-23  120  		asm volatile("pushfq; popq %0" :"=m"(newregs->flags));
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30  121  #endif
de0d22e50cd3d5 arch/x86/include/asm/kexec.h Nick Desaulniers 2018-10-30  122  		newregs->ip = _THIS_IP_;
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30  123  	}
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30  124  }
3c233d1334ffc8 include/asm-x86/kexec.h      Harvey Harrison  2008-01-30  125  

:::::: The code at line 98 was first introduced by commit
:::::: b69a3f9dc0bbdbf9278ac5bc8d4b6347c11a701b include/asm-x86/kexec.h: checkpatch cleanups - formatting only

:::::: TO: Joe Perches <joe@xxxxxxxxxxx>
:::::: CC: Ingo Molnar <mingo@xxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec

[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux