On 08/13/19 13:28, Laszlo Ersek wrote: > On 08/05/19 17:55, ard.biesheuvel at linaro.org (Ard Biesheuvel) wrote: >> I would argue that this means it is not a good place to *create* the >> dummy variable, and if we don't create it, we don't have to delete it >> either. > - Consider moving the cleanup even for cold boot to a different spot. > I'd argue for efi_query_variable_store() -- we should delete the dummy > variable there, *regardless* of whether we just created it, or it had > existed previously. To clarify: I suggest deleting the dummy -- regardless of it pre-existing, vs. us creating it on the spot -- *wherever* we create it during cold boot. I'm not arguing for efi_query_variable_store() per se. If there is a better init / setup function, we should move both the creation and the (independent!) removal there. Thanks Laszlo _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
