Hi Christophe, On Mon, Jul 08, 2019 at 12:40:52PM +0200, Christophe Leroy wrote: > > From: Sven Schnelle <svens@xxxxxxxxxxxxxx> > > Please describe you patch. > > All the changes you are doing to the ppc64 version in order to make it > generic should be described. > > Those changes are also maybe worth splitting the patch in several parts, > either preparing the ppc64 for generic then moving to kernel/kexec_elf.c or > moving to kernel/kexec_elf.c without modifications, then modifying it to > make it generic. > > Note that your patch only applies on Linux 5.1, it doesn't apply on > powerpc/next. > > I think it also be worth taking the opportunity to fix the sparse warnings, > see https://patchwork.ozlabs.org/patch/1128720/ > > checkpatch comments should also be fixed, see https://openpower.xyz/job/snowpatch/job/snowpatch-linux-checkpatch/8044//artifact/linux/checkpatch.log Actually this patch shouldn't have been sent out, that was my fault. Appologies for that. Thanks for your review, i will split up the patch and resent it. Regards Sven _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
