Hi Boris, On 3/25/19 1:37 AM, Borislav Petkov wrote: > On Mon, Mar 25, 2019 at 09:58:07AM +0800, lijiang wrote: >> For the SEV virtual machine, it maps the kexec memroy area as >> encrypted, so, no need to invoke this function to change anything. > > Look at the code: > > set_memory_decrypted->__set_memory_enc_dec > > It already *does* invoke this function. > By default all the memory regions are mapped encrypted. The set_memory_{encrypt,decrypt}() is a generic function which can be called explicitly to clear/set the encryption mask from the existing memory mapping. The mem_encrypt_active() returns true if either SEV or SME is active. So the __set_memory_enc_dec() uses the memory_encrypt_active() check to ensure that the function is no-op when SME/SEV are not active. Currently, the arch_kexec_post_alloc_pages() unconditionally clear the encryption mask from the kexec area. In case of SEV, we should not clear the encryption mask. >>> if (!mem_encrypt_active()) >>> >>> and heads will spin from all the checking of memory encryption aspects. >>> >>> So this would need a rework so that there are no multiple confusing >>> checks. >> >> About the three functions, here i copied their comment from the arch/x86/mm/mem_encrypt.c >> Please refer to it. > > I know that comment - I have asked for it. Now you go and look at the > code again with your patch applied. > _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec