RE: [PATCH v2] makedumpfile: honor the CFLAGS from environment variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/28/2019 10:14 PM, Kairui Song wrote:
> This makes it possible to pass in extra cflags, for example, hardening
> flags could be passed in with environment variable when building a
> hardened package.
> 
> Also introduce a CFLAGS_BASE to hold common CFLAGS, which simplify the
> CFLAGS definition.
> 
> Suggested-by: Kazuhito Hagio <k-hagio@xxxxxxxxxxxxx>
> Signed-off-by: Kairui Song <kasong@xxxxxxxxxx>
> ---
> Update from V1:
>   - Use a CFLAGS_BASE to simplify CFLAGS definition
>   - Use immediate set rather than lazy set to avoid unexpected
>     flag duplication
> 
>  Makefile | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 612b9d0..bca9984 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -8,11 +8,10 @@ ifeq ($(strip $CC),)
>  CC	= gcc
>  endif
> 
> -CFLAGS = -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \
> -	  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE \
> -	  -DVERSION='"$(VERSION)"' -DRELEASE_DATE='"$(DATE)"'
> -CFLAGS_ARCH	= -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \
> -		    -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> +CFLAGS_BASE := $(CFLAGS) -g -O2 -Wall -D_FILE_OFFSET_BITS=64 \
> +                -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
> +CFLAGS      := $(CFLAGS_BASE) -DVERSION='"$(VERSION)"' -DRELEASE_DATE='"$(DATE)"'
> +CFLAGS_ARCH := $(CFLAGS_BASE)
>  # LDFLAGS = -L/usr/local/lib -I/usr/local/include
> 
>  HOST_ARCH := $(shell uname -m)
> --
> 2.20.1
> 

Thank you Kairui, applied.

Kazu



_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux