Re: [PATCH] purgatory: Use standalond CFLAGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 28, 2019 at 06:50:40PM +0800, Kairui Song wrote:
> There has been a lot of workarounds for purgatory disabling many
> specified CFLAGS that will break purgatory. It will be better to not
> let the CFLAGS used to compile purgatory honor the CFLAGS from
> environment variables. So we will have stable CFLAGS for purgatory.
> 
> If anyone still wants to change purgatory CFLAGS, PURGATORY_EXTRA_CFLAGS
> is still honored.

Thanks, this seems reasonable to me.
But I'd like to wait to see if there is feedback from others before applying.

> 
> ---
>  purgatory/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/purgatory/Makefile b/purgatory/Makefile
> index 49ce80a..2dd6c47 100644
> --- a/purgatory/Makefile
> +++ b/purgatory/Makefile
> @@ -45,7 +45,7 @@ purgatory/sha256.o: $(srcdir)/util_lib/sha256.c
>  	$(COMPILE.c) -o $@ $^
>  
>  $(PURGATORY): CC=$(TARGET_CC)
> -$(PURGATORY): CFLAGS+=$(PURGATORY_EXTRA_CFLAGS) \
> +$(PURGATORY): CFLAGS=$(PURGATORY_EXTRA_CFLAGS) \
>  		      $($(ARCH)_PURGATORY_EXTRA_CFLAGS) \
>  		      -Os -fno-builtin -ffreestanding \
>  		      -fno-zero-initialized-in-bss \
> -- 
> 2.20.1
> 

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux