Hi Vicenç, Happy New Year to you too and thanks a lot for your test results. On Thu, Jan 3, 2019 at 10:23 PM Vicente Bergas <vicencb@xxxxxxxxx> wrote: > > On Wed, Dec 26, 2018 at 5:53 AM Bhupesh Sharma <bhsharma@xxxxxxxxxx> wrote: > > > > Hello Vicenç, > > > > On Mon, Dec 17, 2018 at 12:47 AM Bhupesh Sharma <bhsharma@xxxxxxxxxx> wrote: > > > > > > Changes since v2: > > > ----------------- > > > - Dropped 4/4 from v2 as I noticed that we pass wrong node name to fdt > > > helper functions in 'kexec/dt-ops.c' > > > > > > This patchset fixes some issues when we call kexec for arm64 with --dtb > > > option (both for 'kexec load' and 'kdump' use cases). > > > > > > A couple of these issues were reported for 'kexec load' use case by > > > Vicenç and I found the other two while experiment with 'kdump' use > > > cases. > > > > > > I have tested the patchset on my qualcomm-amberwing and hp-moonshot > > > arm64 boards. > > > > > > Cc: Simon Horman <horms@xxxxxxxxxxxx> > > > Cc: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> > > > Cc: Vicente Bergas <vicencb@xxxxxxxxx> > > > > > > Bhupesh Sharma (4): > > > kexec/dt-ops.c: Fix check against 'fdt_add_subnode' return value > > > kexec/kexec-arm64.c: Add error handling check against return value of > > > 'set_bootargs()' > > > kexec/dt-ops.c: Fix adding '/chosen' node for cases where it is not > > > available in dtb passed via --dtb option > > > kexec/dt-ops.c: Fix '/chosen' v/s 'chosen' node being passed to fdt > > > helper functions > > > > > > kexec/arch/arm64/kexec-arm64.c | 5 +++++ > > > kexec/dt-ops.c | 36 ++++++++++++++++++++++++++++++------ > > > 2 files changed, 35 insertions(+), 6 deletions(-) > > > > > > -- > > > 2.7.4 > > > > > > > Can you please give this patchset a try at your end and see if it > > fixes the issues you had reported with the --dtb option. > > Hi Bhupesh, > sorry for the delay. > This is what I have tested: > kexec --append 'debug' > --load Image > kexec --reuse-cmdline > --load Image > kexec --append 'debug' --dtb rk3399-sapphire.dtb > --load Image > kexec --reuse-cmdline --dtb rk3399-sapphire.dtb > --load Image > kexec --append 'debug' --dtb rk3399-gru-kevin.dtb > --load Image > kexec --reuse-cmdline --dtb rk3399-gru-kevin.dtb > --load Image > kexec --append 'debug' --ramdisk > initramfs-linux.img --load Image > kexec --reuse-cmdline --ramdisk > initramfs-linux.img --load Image > kexec --append 'debug' --dtb rk3399-sapphire.dtb --ramdisk > initramfs-linux.img --load Image > kexec --reuse-cmdline --dtb rk3399-sapphire.dtb --ramdisk > initramfs-linux.img --load Image > kexec --append 'debug' --dtb rk3399-gru-kevin.dtb --ramdisk > initramfs-linux.img --load Image > kexec --reuse-cmdline --dtb rk3399-gru-kevin.dtb --ramdisk > initramfs-linux.img --load Image > > where the sapphire dtb has no chosen node and the gru has. > Everything worked OK. > @Simon: Hi, Since this works fine at Vicenç's end as well, can you please consider applying this to kexec-tools as this issue has been reported by another arm64 user as well. Thanks for your help. Regards, Bhupesh _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
