On 10/31/2018 6:10 AM, Borislav Petkov wrote: > On Wed, Oct 31, 2018 at 10:47:48AM +0800, Dave Young wrote: > > It is a mist only a few kdump people know them, documenting them will help > > people to understand and review. It will also be clearer instead of > > digging into code? > > Wholeheartedly agreed. Especially if people start using vmcoreinfo for > other stuff, like live debugging: > > https://lkml.kernel.org/r/1540593788-28181-1-git-send-email-bhsharma@xxxxxxxxxx I also agree. If it can help reviewers and other users to understand vmcoreinfo and can help itself to become more standard, it would be better to write it. One small thing as a vmcoreinfo user (not about the documentation), I think it might be better to export each information to each variable separately, not OR-ing them into a variable, because of code simpleness of both kernel and tools, if there is no limitation in kernel. Thanks, Kazu _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
