Hi, On Fri, Sep 21, 2018 at 8:18 AM, zhong jiang <zhongjiang@xxxxxxxxxx> wrote: > We include kexec.h and slab.h twice in kexec_file.c. It's unnecessary. > hence just remove them. > > Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx> > --- > kernel/kexec_file.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index c6a3b68..35cf0ad 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -25,8 +25,6 @@ > #include <linux/elf.h> > #include <linux/elfcore.h> > #include <linux/kernel.h> > -#include <linux/kexec.h> > -#include <linux/slab.h> > #include <linux/syscalls.h> > #include <linux/vmalloc.h> > #include "kexec_internal.h" > -- > 1.7.12.4 > Nice catch. Reviewed-by: Bhupesh Sharma <bhsharma@xxxxxxxxxx> BTW while we are at it, can you also send out a separate patch to list the include files in this file (i.e. kexec_file.c) alphabetically (similar to other linux source files - see <https://patchwork.kernel.org/patch/10258279/> for example). Something like: #include <crypto/hash.h> #include <crypto/sha.h> #include <linux/capability.h> #include <linux/elf.h> #include <linux/elfcore.h> #include <linux/file.h> #include <linux/fs.h> #include <linux/ima.h> #include <linux/kernel.h> #include <linux/kexec.h> #include <linux/list.h> #include <linux/mm.h> #include <linux/mutex.h> #include <linux/slab.h> #include <linux/syscalls.h> #include <linux/vmalloc.h> #include "kexec_internal.h" This will improve readability and also reduce similar instances of include files being added twice in this source file in future. Thanks, Bhupesh _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
