On Tue, Aug 21, 2018 at 5:40 AM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote: > > Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > > > On Mon, Aug 20, 2018 at 10:58 AM Nick Desaulniers > > <ndesaulniers@xxxxxxxxxx> wrote: > >> > >> + akpm, Linus > >> > >> Bumping for review. > > > > Ugh. I am not personally a huge fan of this endless "fix up one at a time". > > > > Just do a patch that removes current_text_addr() entirely and be done > > with it, if that's what we want the end result to be. > > > > Don't bother with these small "let's remove the remaining ones one by > > one". Just get it over and done with. Linus, No problem. Will send a V2 that rips off the band-aid. I explained my thoughts on the process more in https://lkml.org/lkml/2018/8/1/1689, which akpm agreed with. I was hoping that I wouldn't have to bother you with a tree-wide change, but if code review takes 3 weeks... Also, I was hoping to save the small but many clean ups as starter patches for some newbies that we're asking me how to get started contributing to the kernel, but I can find other good first bugs for them. > > One is generic code the other is assembly but the both appear to do the > same thing without unexpected complexity. > > That said the patch earlier in this thread has clearly never been > compiled as it is using THIS_IP instead of _THIS_IP_ and there is not > a define of THIS_IP in the kernel. Eric, Please triple check your email client or whatever you're using to download patches, as I suspect one of them may be stripping leading+trailing underscores. That would be quite problematic for code review or applying patch files. I've seen some text renderers treat the underscores as markdown and italicize the contained word. https://lkml.org/lkml/2018/8/1/1608 shows the underscores. -- Thanks, ~Nick Desaulniers _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
