Hi Will, On Mon, Jul 23, 2018 at 7:05 PM, Will Deacon <will.deacon@xxxxxxx> wrote: > On Tue, Jul 17, 2018 at 02:12:23PM +0900, AKASHI Takahiro wrote: >> On Fri, Jul 13, 2018 at 07:49:45AM +0200, Ard Biesheuvel wrote: >> > On 13 July 2018 at 02:34, AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> wrote: >> > > On Thu, Jul 12, 2018 at 05:49:19PM +0100, Will Deacon wrote: >> > >> Hi Akashi, >> > >> >> > >> On Tue, Jul 10, 2018 at 08:42:25AM +0900, AKASHI Takahiro wrote: >> > >> > This patch series is a set of bug fixes to address kexec/kdump >> > >> > failures which are sometimes observed on ACPI-only system and reported >> > >> > in LAK-ML before. >> > >> >> > >> I tried picking this up, along with Ard's fixup, but I'm seeing a build >> > >> failure for allmodconfig: >> > >> >> > >> arch/arm64/kernel/acpi.o: In function `__acpi_get_mem_attribute': >> > >> acpi.c:(.text+0x60): undefined reference to `efi_mem_attributes' >> > >> >> > >> I didn't investigate further. Please can you fix this? >> > > >> > > Because CONFIG_ACPI is on and CONFIG_EFI is off. >> > > >> > > This can happen in allmodconfig as CONFIG_EFI depends on >> > > !CONFIG_CPU_BIG_ENDIAN, which is actually on in this case. >> > > >> > >> > Allowing both CONFIG_ACPI and CONFIG_CPU_BIG_ENDIAN to be configured >> > makes no sense at all. Things will surely break if you start using BE >> > memory accesses while parsing ACPI tables. >> > >> > Allowing CONFIG_ACPI without CONFIG_EFI makes no sense either, since >> > on arm64, the only way to find the ACPI tables is through a UEFI >> > configuration table. >> >> >> Do you agree to this? > > Yes; please post a new series which resolves these dependencies and includes > Ard's fixup from before. I see that Akashi has already posted a v4 here with the suggested fixes: https://lkml.org/lkml/2018/7/22/321 Thanks, Bhupesh _______________________________________________ kexec mailing list kexec@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/kexec
