Re: [PATCH 0/1] x86/purgatory: Fix Makefile bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andrew,

can you send this fix to Linus like the original patch?

Can you also tell me if the bug is severe enough to go to stable? For
productive systems the bug shouldn't cause any problem because they are usually
build from scratch. For developers however, it can cause quite a pain while
debugging.

@Dave: Thanks for looking into this.

Thanks
Philipp


On Fri, 6 Jul 2018 16:30:29 +0800
Dave Young <dyoung@xxxxxxxxxx> wrote:

> Hi Philipp,
> 
> On 07/05/18 at 10:43am, Philipp Rudo wrote:
> > Hi Dave,
> > 
> > On Thu, 5 Jul 2018 14:46:20 +0800
> > Dave Young <dyoung@xxxxxxxxxx> wrote:
> >   
> > > On 07/04/18 at 01:00pm, Philipp Rudo wrote:  
> > > > Hi everybody,
> > > > 
> > > > when i moved the purgatories sha256 implementation to common code, i forgot
> > > > to add FORCE to the new Makefile target. This patch fixes it.    
> > > 
> > > Hi Philipp,
> > > 
> > > Do you have the exact steps of how to reproduce your problem?  
> > 
> > I only tested it on s390, but on x86 it should work the same way.
> > 
> > - Build the kernel without the fix
> > - Add some flag to the purgatories KBUILD_CFLAGS,I used
> >   -fno-asynchronous-unwind-tables
> > - Re-build the kernel
> > 
> > When you look at make's output you see that sha256.o is not re-build in the
> > last step. Also readelf -S still shows the .eh_frame section for sha256.o.
> > 
> > With the fix sha256.o is re-build in the last step.
> > 
> > Hope that helps.  
> 
> Thanks for explanation.
> 
> For the patch:
> Acked-by: Dave Young <dyoung@xxxxxxxxxx>
> 
> Thanks
> Dave
> 


_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux