Re: [PATCH v2] Remove obsolete kdump tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Simon,

On Fri, May 25, 2018 at 3:32 PM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Fri, May 25, 2018 at 04:00:33PM +0800, Dave Young wrote:
>> On 05/24/18 at 01:08pm, Bhupesh Sharma wrote:
>> > The kdump tool presently allows one to generate an ELF file containing
>> > the ELF header, PT_NOTE and PT_LOAD segments (which can be analyzed
>> > later by tools like 'readelf') of the crashdump read from memory, when
>> > passed with an appropriate 'elfcorehdr' value(which represents the
>> > physical address of the start of the ELF header).
>> >
>> > With the availability of tools like crash/gdb the analysis of the
>> > crashdump core has become rather easy, and it makes the kdump tool
>> > obsolete. Also the same naming convention (man page) causes confusion
>> > when compared to similarly named distribution specific kdump
>> > service/utilities.
>> >
>> > Also most distributions (like Fedora for e.g.) now support more
>> > enhanced kdump service and utilities which can be used to analyze the
>> > crashdump core contents better. Taking an example of the Fedora
>> > specific kdump service and utilities, the following sequence of steps
>> > happen when the primary kernel crashes:
>> >
>> > 1. If the crashkernel is loaded, then the system starts executing the
>> > same.
>> >
>> > 2. When the boot process gets to the point when kdump service is
>> > started, the crashdump core is usually copied out to disk (for e.g.
>> > inside '/var/crash') using 'cp' command from '/proc/vmcore':
>> >    # cp /proc/vmcore <dump-file>
>> >
>> > 3. Thereafter the system is rebooted back into the normal kernel.
>> >
>> > 4. Once back to your normal kernel, one can use the crashdump core
>> > available on hard disk in conjunction with the previously installed
>> > kernel (with debuginfo) to perform postmortem analysis with tools like
>> > gdb/crash:
>> >    # gdb vmlinux <dump-file>
>> >
>> > Accordingly, this patch removes the obsolete kdump tool from
>> > 'kexec-tools'.
>>
>> The main issue for me is the manpage kdump.8 cause confusion to people
>> The kdump tools is not a main problem to exist or not, but I think
>> removing the kdump tool along with the man page looks a good cleanup :)
>>
>> Reviewed-by: Dave Young <dyoung@xxxxxxxxxx>
>
> Thanks, applied.

Thanks for applying this patch, but it seems some files were missed
while applying the patch.

I can see that while the changes for Makefile.in where picked (please
see <https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/>
for details), the kdump directory is still present in the tree (please
see <https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/tree/kdump>
for details).

Regards,
Bhupesh

_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux